Skip to content

Commit

Permalink
Update extension install prompt to match latest mocks
Browse files Browse the repository at this point in the history 
XIB changes:
* Made all windows 468 pixels wide
* Moved controls to match mocks
* Added an outlet for the store link button

Mock: http://i.imgur.com/ruUmn.png

Screenshots of new UI:
  Warnings: http://i.imgur.com/5urhd.png
  No Warnings: http://i.imgur.com/UrHif.png
  Inline: http://i.imgur.com/nrHWQ.png
  Inline No Warnings: http://i.imgur.com/Mgbgs.png
  Bundle: http://i.imgur.com/mexGe.png

Screenshots old original UI:
  Warnings: http://i.imgur.com/nVqgA.png
  No Warnings: http://i.imgur.com/fSkGb.png
  Inline: http://i.imgur.com/S7gBE.png
  Inline No Warnings: http://i.imgur.com/pJJdx.png
  Bundle: http://i.imgur.com/7h7QO.png

BUG=155803
TBR=sky@chromium.org
TEST=
  Warnings: Install extension from: https://chrome.google.com/webstore/detail/google-mail-checker/mihcahmgecmbnbcchbopgniflfhgnkff
  No Warnings: https://chrome.google.com/webstore/detail/seo-analysis-with-seoptim/pplbjgemahdghhnelnlihpflpdkkmmgj
  Inline: Navigate to https://www.google.com/chrome/intl/en/p/google-plus.html and add Google+ Notifications
  Inline No Warnings: Same as above but instead add Google+ App
  Bundle: Run Chrome with --apps-gallery-url="http://www.corp.google.com/" and navigate to http://www.corp.google.com/~jstritar/bundle.html


Review URL: https://chromiumcodereview.appspot.com/11275269

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167512 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
sail@chromium.org committed Nov 13, 2012
1 parent 6aa694b commit df023e2
Show file tree
Hide file tree
Showing 8 changed files with 279 additions and 131 deletions.
187 changes: 157 additions & 30 deletions chrome/app/nibs/ExtensionInstallPrompt.xib
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
<archive type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="7.10">
<data>
<int key="IBDocument.SystemTarget">1050</int>
<string key="IBDocument.SystemVersion">12B19</string>
<string key="IBDocument.SystemVersion">12C54</string>
<string key="IBDocument.InterfaceBuilderVersion">2549</string>
<string key="IBDocument.AppKitVersion">1187</string>
<string key="IBDocument.HIToolboxVersion">624.00</string>
<string key="IBDocument.AppKitVersion">1187.34</string>
<string key="IBDocument.HIToolboxVersion">625.00</string>
<object class="NSMutableDictionary" key="IBDocument.PluginVersions">
<string key="NS.key.0">com.apple.InterfaceBuilder.CocoaPlugin</string>
<string key="NS.object.0">2549</string>
Expand Down Expand Up @@ -68,10 +68,10 @@
<object class="NSOutlineView" id="293999151">
<reference key="NSNextResponder" ref="544761792"/>
<int key="NSvFlags">4352</int>
<string key="NSFrameSize">{301, 34}</string>
<string key="NSFrameSize">{378, 48}</string>
<reference key="NSSuperview" ref="544761792"/>
<reference key="NSWindow"/>
<reference key="NSNextKeyView" ref="111827522"/>
<reference key="NSNextKeyView" ref="636351768"/>
<bool key="NSEnabled">YES</bool>
<bool key="NSAllowsLogicalLayoutDirection">NO</bool>
<bool key="NSControlAllowsExpansionToolTips">YES</bool>
Expand All @@ -83,17 +83,17 @@
<object class="NSMutableArray" key="NSTableColumns">
<bool key="EncodedWithXMLCoder">YES</bool>
<object class="NSTableColumn" id="293250585">
<double key="NSWidth">298</double>
<double key="NSWidth">375</double>
<double key="NSMinWidth">16</double>
<double key="NSMaxWidth">1000</double>
<object class="NSTableHeaderCell" key="NSHeaderCell">
<int key="NSCellFlags">75497536</int>
<int key="NSCellFlags2">2048</int>
<string key="NSContents"/>
<object class="NSFont" key="NSSupport">
<object class="NSFont" key="NSSupport" id="235035229">
<string key="NSName">LucidaGrande</string>
<double key="NSSize">11</double>
<int key="NSfFlags">3100</int>
<double key="NSSize">12</double>
<int key="NSfFlags">16</int>
</object>
<object class="NSColor" key="NSBackgroundColor">
<int key="NSColorSpace">3</int>
Expand All @@ -113,11 +113,7 @@
<int key="NSCellFlags">337641536</int>
<int key="NSCellFlags2">2048</int>
<string key="NSContents">Text Cell</string>
<object class="NSFont" key="NSSupport">
<string key="NSName">LucidaGrande</string>
<double key="NSSize">11</double>
<int key="NSfFlags">16</int>
</object>
<reference key="NSSupport" ref="235035229"/>
<reference key="NSControlView" ref="293999151"/>
<object class="NSColor" key="NSBackgroundColor" id="957923968">
<int key="NSColorSpace">6</int>
Expand All @@ -128,9 +124,9 @@
<bytes key="NSWhite">MC42NjY2NjY2NjY3AA</bytes>
</object>
</object>
<object class="NSColor" key="NSTextColor">
<object class="NSColor" key="NSTextColor" id="387827301">
<int key="NSColorSpace">1</int>
<bytes key="NSRGB">MC4yMTU2ODYyNzQ1IDAuMjE1Njg2Mjc0NSAwLjIxNTY4NjI3NDUAA</bytes>
<bytes key="NSRGB">MCAwIDAAA</bytes>
</object>
</object>
<reference key="NSTableView" ref="293999151"/>
Expand Down Expand Up @@ -164,7 +160,7 @@
<bool key="NSOutlineViewAutoresizesOutlineColumnKey">NO</bool>
</object>
</object>
<string key="NSFrameSize">{298, 34}</string>
<string key="NSFrameSize">{376, 48}</string>
<reference key="NSSuperview" ref="385892238"/>
<reference key="NSWindow"/>
<reference key="NSNextKeyView" ref="293999151"/>
Expand Down Expand Up @@ -199,10 +195,10 @@
<double key="NSPercent">0.99665551839464883</double>
</object>
</object>
<string key="NSFrame">{{-2, 76}, {298, 34}}</string>
<string key="NSFrame">{{0, 62}, {376, 48}}</string>
<reference key="NSSuperview" ref="359431345"/>
<reference key="NSWindow"/>
<reference key="NSNextKeyView" ref="636351768"/>
<reference key="NSNextKeyView" ref="544761792"/>
<int key="NSsFlags">133760</int>
<reference key="NSVScroller" ref="636351768"/>
<reference key="NSHScroller" ref="858919758"/>
Expand All @@ -227,7 +223,7 @@
<string>NeXT TIFF v4.0 pasteboard type</string>
</object>
</object>
<string key="NSFrame">{{301, 66}, {69, 69}}</string>
<string key="NSFrame">{{380, 64}, {69, 69}}</string>
<reference key="NSSuperview" ref="359431345"/>
<reference key="NSWindow"/>
<reference key="NSNextKeyView" ref="212922230"/>
Expand All @@ -246,7 +242,7 @@
<object class="NSButton" id="212922230">
<reference key="NSNextResponder" ref="359431345"/>
<int key="NSvFlags">289</int>
<string key="NSFrame">{{172, 14}, {96, 28}}</string>
<string key="NSFrame">{{246, 19}, {96, 28}}</string>
<reference key="NSSuperview" ref="359431345"/>
<reference key="NSWindow"/>
<reference key="NSNextKeyView" ref="35876364"/>
Expand All @@ -273,7 +269,7 @@
<object class="NSButton" id="35876364">
<reference key="NSNextResponder" ref="359431345"/>
<int key="NSvFlags">289</int>
<string key="NSFrame">{{274, 14}, {96, 28}}</string>
<string key="NSFrame">{{352, 19}, {96, 28}}</string>
<reference key="NSSuperview" ref="359431345"/>
<reference key="NSWindow"/>
<bool key="NSEnabled">YES</bool>
Expand Down Expand Up @@ -314,7 +310,7 @@ ARcABAAAAAEAAAACARwAAwAAAAEAAQAAAVIAAwAAAAEAAQAAAVMAAwAAAAIAAQABAAAAAA</bytes>
<object class="NSTextField" id="931530361">
<reference key="NSNextResponder" ref="359431345"/>
<int key="NSvFlags">268</int>
<string key="NSFrame">{{17, 118}, {276, 17}}</string>
<string key="NSFrame">{{19, 118}, {357, 17}}</string>
<reference key="NSSuperview" ref="359431345"/>
<reference key="NSWindow"/>
<reference key="NSNextKeyView" ref="385892238"/>
Expand All @@ -324,8 +320,8 @@ ARcABAAAAAEAAAACARwAAwAAAAEAAQAAAVIAAwAAAAEAAQAAAVMAAwAAAAIAAQABAAAAAA</bytes>
<int key="NSCellFlags2">272629760</int>
<string key="NSContents">Title</string>
<object class="NSFont" key="NSSupport">
<string key="NSName">LucidaGrande-Bold</string>
<double key="NSSize">13</double>
<string key="NSName">LucidaGrande</string>
<double key="NSSize">15</double>
<int key="NSfFlags">16</int>
</object>
<reference key="NSControlView" ref="931530361"/>
Expand All @@ -335,15 +331,12 @@ ARcABAAAAAEAAAACARwAAwAAAAEAAQAAAVIAAwAAAAEAAQAAAVMAAwAAAAIAAQABAAAAAA</bytes>
<string key="NSColorName">controlColor</string>
<reference key="NSColor" ref="977270170"/>
</object>
<object class="NSColor" key="NSTextColor">
<int key="NSColorSpace">1</int>
<bytes key="NSRGB">MC4yMTU2ODYyNzQ1IDAuMjE1Njg2Mjc0NSAwLjIxNTY4NjI3NDUAA</bytes>
</object>
<reference key="NSTextColor" ref="387827301"/>
</object>
<bool key="NSAllowsLogicalLayoutDirection">NO</bool>
</object>
</object>
<string key="NSFrameSize">{387, 149}</string>
<string key="NSFrameSize">{468, 149}</string>
<reference key="NSSuperview"/>
<reference key="NSWindow"/>
<reference key="NSNextKeyView" ref="931530361"/>
Expand Down Expand Up @@ -706,6 +699,140 @@ ARcABAAAAAEAAAACARwAAwAAAAEAAQAAAVIAAwAAAAEAAQAAAVMAAwAAAAIAAQABAAAAAA</bytes>
<object class="IBPartialClassDescription">
<string key="className">ExtensionInstallViewController</string>
<string key="superclassName">NSViewController</string>
<object class="NSMutableDictionary" key="actions">
<bool key="EncodedWithXMLCoder">YES</bool>
<object class="NSArray" key="dict.sortedKeys">
<bool key="EncodedWithXMLCoder">YES</bool>
<string>cancel:</string>
<string>ok:</string>
<string>storeLinkClicked:</string>
</object>
<object class="NSArray" key="dict.values">
<bool key="EncodedWithXMLCoder">YES</bool>
<string>id</string>
<string>id</string>
<string>id</string>
</object>
</object>
<object class="NSMutableDictionary" key="actionInfosByName">
<bool key="EncodedWithXMLCoder">YES</bool>
<object class="NSArray" key="dict.sortedKeys">
<bool key="EncodedWithXMLCoder">YES</bool>
<string>cancel:</string>
<string>ok:</string>
<string>storeLinkClicked:</string>
</object>
<object class="NSArray" key="dict.values">
<bool key="EncodedWithXMLCoder">YES</bool>
<object class="IBActionInfo">
<string key="name">cancel:</string>
<string key="candidateClassName">id</string>
</object>
<object class="IBActionInfo">
<string key="name">ok:</string>
<string key="candidateClassName">id</string>
</object>
<object class="IBActionInfo">
<string key="name">storeLinkClicked:</string>
<string key="candidateClassName">id</string>
</object>
</object>
</object>
<object class="NSMutableDictionary" key="outlets">
<bool key="EncodedWithXMLCoder">YES</bool>
<object class="NSArray" key="dict.sortedKeys">
<bool key="EncodedWithXMLCoder">YES</bool>
<string>cancelButton_</string>
<string>iconView_</string>
<string>itemsField_</string>
<string>okButton_</string>
<string>outlineView_</string>
<string>ratingCountField_</string>
<string>ratingStars_</string>
<string>storeLinkButton_</string>
<string>titleField_</string>
<string>userCountField_</string>
<string>warningsSeparator_</string>
</object>
<object class="NSArray" key="dict.values">
<bool key="EncodedWithXMLCoder">YES</bool>
<string>NSButton</string>
<string>NSImageView</string>
<string>NSTextField</string>
<string>NSButton</string>
<string>NSOutlineView</string>
<string>NSTextField</string>
<string>NSView</string>
<string>NSButton</string>
<string>NSTextField</string>
<string>NSTextField</string>
<string>NSBox</string>
</object>
</object>
<object class="NSMutableDictionary" key="toOneOutletInfosByName">
<bool key="EncodedWithXMLCoder">YES</bool>
<object class="NSArray" key="dict.sortedKeys">
<bool key="EncodedWithXMLCoder">YES</bool>
<string>cancelButton_</string>
<string>iconView_</string>
<string>itemsField_</string>
<string>okButton_</string>
<string>outlineView_</string>
<string>ratingCountField_</string>
<string>ratingStars_</string>
<string>storeLinkButton_</string>
<string>titleField_</string>
<string>userCountField_</string>
<string>warningsSeparator_</string>
</object>
<object class="NSArray" key="dict.values">
<bool key="EncodedWithXMLCoder">YES</bool>
<object class="IBToOneOutletInfo">
<string key="name">cancelButton_</string>
<string key="candidateClassName">NSButton</string>
</object>
<object class="IBToOneOutletInfo">
<string key="name">iconView_</string>
<string key="candidateClassName">NSImageView</string>
</object>
<object class="IBToOneOutletInfo">
<string key="name">itemsField_</string>
<string key="candidateClassName">NSTextField</string>
</object>
<object class="IBToOneOutletInfo">
<string key="name">okButton_</string>
<string key="candidateClassName">NSButton</string>
</object>
<object class="IBToOneOutletInfo">
<string key="name">outlineView_</string>
<string key="candidateClassName">NSOutlineView</string>
</object>
<object class="IBToOneOutletInfo">
<string key="name">ratingCountField_</string>
<string key="candidateClassName">NSTextField</string>
</object>
<object class="IBToOneOutletInfo">
<string key="name">ratingStars_</string>
<string key="candidateClassName">NSView</string>
</object>
<object class="IBToOneOutletInfo">
<string key="name">storeLinkButton_</string>
<string key="candidateClassName">NSButton</string>
</object>
<object class="IBToOneOutletInfo">
<string key="name">titleField_</string>
<string key="candidateClassName">NSTextField</string>
</object>
<object class="IBToOneOutletInfo">
<string key="name">userCountField_</string>
<string key="candidateClassName">NSTextField</string>
</object>
<object class="IBToOneOutletInfo">
<string key="name">warningsSeparator_</string>
<string key="candidateClassName">NSBox</string>
</object>
</object>
</object>
<object class="IBClassDescriptionSource" key="sourceIdentifier">
<string key="majorKey">IBProjectSource</string>
<string key="minorKey">./Classes/ExtensionInstallViewController.h</string>
Expand Down
Loading

0 comments on commit df023e2

Please sign in to comment.