Cleanup remaining class/struct fwd declarations

Remove remaining useless class and struct forward declarations from Chromium (excluding third_party directory) using a homemade script available in bug 662195 comments. An up-and-running presubmit check is now available and should prevent new useless forward declarations to come up. BUG=662195 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_nacl_sdk Review-Url: https://codereview.chromium.org/2554863002 Cr-Commit-Position: refs/heads/master@{#436883}
hylschwy · Dec 7, 2016 · db24b9e · db24b9e
1 parent 16fd4e9
commit db24b9e
Show file tree

Hide file tree

Showing 85 changed files with 11 additions and 172 deletions.
diff --git a/apps/app_lifetime_monitor.h b/apps/app_lifetime_monitor.h
@@ -14,10 +14,6 @@
 #include "content/public/browser/notification_registrar.h"
 #include "extensions/browser/app_window/app_window_registry.h"
 
-namespace extensions {
-class Extension;
-}
-
 class Profile;
 
 namespace apps {

diff --git a/apps/ui/views/app_window_frame_view.h b/apps/ui/views/app_window_frame_view.h
@@ -14,8 +14,6 @@
 #include "ui/views/controls/button/button.h"
 #include "ui/views/window/non_client_view.h"
 
-class SkRegion;
-
 namespace extensions {
 class NativeAppWindow;
 }

diff --git a/cc/output/in_process_context_provider.h b/cc/output/in_process_context_provider.h
@@ -25,10 +25,6 @@ class GLInProcessContext;
 class GpuMemoryBufferManager;
 class ImageFactory;
 struct SharedMemoryLimits;
-class SyncPointManager;
-namespace gles2 {
-class MailboxManager;
-}
 }
 
 namespace skia_bindings {

diff --git a/cc/trees/proxy_main.h b/cc/trees/proxy_main.h
@@ -13,7 +13,6 @@
 
 namespace cc {
 
-class BeginFrameSource;
 class MutatorEvents;
 class CompletionEvent;
 class CompositorFrameSink;

diff --git a/components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.h b/components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.h
@@ -15,6 +15,7 @@
 
 class AccountTrackerService;
 class ProfileOAuth2TokenServiceIOSProvider;
+class SigninClient;
 
 class ProfileOAuth2TokenServiceIOSDelegate : public OAuth2TokenServiceDelegate {
  public:

diff --git a/courgette/courgette.h b/courgette/courgette.h
@@ -63,7 +63,6 @@ enum ExecutableType {
 class SinkStream;
 class SinkStreamSet;
 class SourceStream;
-class SourceStreamSet;
 
 class AssemblyProgram;
 class EncodedProgram;

diff --git a/courgette/disassembler_elf_32_arm.h b/courgette/disassembler_elf_32_arm.h
@@ -16,7 +16,6 @@
 
 namespace courgette {
 
-class AssemblyProgram;
 class InstructionReceptor;
 
 enum ARM_RVA {

diff --git a/courgette/disassembler_elf_32_x86.h b/courgette/disassembler_elf_32_x86.h
@@ -16,7 +16,6 @@
 
 namespace courgette {
 
-class AssemblyProgram;
 class InstructionReceptor;
 
 class DisassemblerElf32X86 : public DisassemblerElf32 {

diff --git a/courgette/disassembler_win32_x64.h b/courgette/disassembler_win32_x64.h
@@ -15,7 +15,6 @@
 
 namespace courgette {
 
-class AssemblyProgram;
 class InstructionReceptor;
 
 class DisassemblerWin32X64 : public DisassemblerWin32 {

diff --git a/courgette/disassembler_win32_x86.h b/courgette/disassembler_win32_x86.h
@@ -15,7 +15,6 @@
 
 namespace courgette {
 
-class AssemblyProgram;
 class InstructionReceptor;
 
 class DisassemblerWin32X86 : public DisassemblerWin32 {

diff --git a/crypto/nss_util.h b/crypto/nss_util.h
@@ -14,7 +14,6 @@
 #include "crypto/crypto_export.h"
 
 namespace base {
-class FilePath;
 class Lock;
 class Time;
 }  // namespace base

diff --git a/dbus/bus.h b/dbus/bus.h
@@ -28,10 +28,6 @@ class SingleThreadTaskRunner;
 class TaskRunner;
 }
 
-namespace tracked_objects {
-class Location;
-}
-
 namespace dbus {
 
 class ExportedObject;

diff --git a/gin/function_template.h b/gin/function_template.h
@@ -17,8 +17,6 @@
 
 namespace gin {
 
-class PerIsolateData;
-
 enum CreateFunctionTemplateFlags {
   HolderIsFirstArgument = 1 << 0,
 };

diff --git a/google_apis/gaia/oauth2_access_token_fetcher_impl.h b/google_apis/gaia/oauth2_access_token_fetcher_impl.h
@@ -25,7 +25,6 @@ class Time;
 namespace net {
 class URLFetcher;
 class URLRequestContextGetter;
-class URLRequestStatus;
 }
 
 // Abstracts the details to get OAuth2 access token token from

diff --git a/google_apis/gaia/oauth2_api_call_flow.h b/google_apis/gaia/oauth2_api_call_flow.h
@@ -13,9 +13,6 @@
 #include "net/url_request/url_fetcher_delegate.h"
 #include "url/gurl.h"
 
-class GoogleServiceAuthError;
-class OAuth2MintTokenFlowTest;
-
 namespace net {
 class URLFetcher;
 class URLRequestContextGetter;

diff --git a/google_apis/gaia/oauth2_mint_token_flow.h b/google_apis/gaia/oauth2_mint_token_flow.h
@@ -26,10 +26,6 @@ namespace content {
 class URLFetcher;
 }
 
-namespace net {
-class URLRequestContextGetter;
-}
-
 // IssueAdvice: messages to show to the user to get a user's approval.
 // The structure is as follows:
 // * Description 1

diff --git a/google_apis/gaia/oauth2_token_service_delegate.h b/google_apis/gaia/oauth2_token_service_delegate.h
@@ -15,8 +15,6 @@ namespace net {
 class URLRequestContextGetter;
 }
 
-class SigninClient;
-
 // Abstract base class to fetch and maintain refresh tokens from various
 // entities. Concrete subclasses should implement RefreshTokenIsAvailable and
 // CreateAccessTokenFetcher properly.

diff --git a/google_apis/gcm/base/mcs_util.h b/google_apis/gcm/base/mcs_util.h
@@ -21,10 +21,6 @@ namespace base {
 class Clock;
 }
 
-namespace net {
-class StreamSocket;
-}
-
 namespace gcm {
 
 // MCS Message tags.

diff --git a/google_apis/gcm/engine/connection_factory_impl.h b/google_apis/gcm/engine/connection_factory_impl.h
@@ -30,7 +30,6 @@ class NetLog;
 
 namespace gcm {
 
-class ConnectionHandlerImpl;
 class GCMStatsRecorder;
 
 class GCM_EXPORT ConnectionFactoryImpl :

diff --git a/google_apis/gcm/engine/connection_handler.h b/google_apis/gcm/engine/connection_handler.h
@@ -26,9 +26,6 @@ class LoginRequest;
 
 namespace gcm {
 
-class SocketInputStream;
-class SocketOutputStream;
-
 // Handles performing the protocol handshake and sending/receiving protobuf
 // messages. Note that no retrying or queueing is enforced at this layer.
 // Once a connection error is encountered, the ConnectionHandler will disconnect

diff --git a/google_apis/gcm/engine/connection_handler_impl.h b/google_apis/gcm/engine/connection_handler_impl.h
@@ -21,6 +21,9 @@ class LoginRequest;
 
 namespace gcm {
 
+class SocketInputStream;
+class SocketOutputStream;
+
 class GCM_EXPORT ConnectionHandlerImpl : public ConnectionHandler {
  public:
   // |read_callback| will be invoked with the contents of any received protobuf

diff --git a/headless/lib/browser/headless_browser_main_parts.h b/headless/lib/browser/headless_browser_main_parts.h
@@ -12,7 +12,6 @@
 
 namespace headless {
 
-class HeadlessBrowserContextImpl;
 class HeadlessBrowserImpl;
 
 class HeadlessBrowserMainParts : public content::BrowserMainParts {

diff --git a/headless/lib/browser/headless_content_browser_client.h b/headless/lib/browser/headless_content_browser_client.h
@@ -10,8 +10,6 @@
 namespace headless {
 
 class HeadlessBrowserImpl;
-class HeadlessBrowserMainParts;
-class HeadlessDevToolsManagerDelegate;
 
 class HeadlessContentBrowserClient : public content::ContentBrowserClient {
  public:

diff --git a/headless/lib/browser/headless_devtools_manager_delegate.h b/headless/lib/browser/headless_devtools_manager_delegate.h
@@ -17,7 +17,6 @@
 namespace headless {
 class HeadlessBrowserImpl;
 class HeadlessBrowserContext;
-class HeadlessWebContentsImpl;
 
 class HeadlessDevToolsManagerDelegate
     : public content::DevToolsManagerDelegate {

diff --git a/headless/lib/browser/headless_screen.h b/headless/lib/browser/headless_screen.h
@@ -19,7 +19,6 @@ class Transform;
 
 namespace aura {
 class Window;
-class WindowParentingClient;
 class WindowTreeHost;
 }
 

diff --git a/headless/lib/browser/headless_url_request_context_getter.h b/headless/lib/browser/headless_url_request_context_getter.h
@@ -19,18 +19,9 @@
 #include "net/url_request/url_request_context_getter.h"
 #include "net/url_request/url_request_job_factory.h"
 
-namespace base {
-class MessageLoop;
-}
-
 namespace net {
 class HostResolver;
-class MappedHostResolver;
-class NetworkDelegate;
-class NetLog;
 class ProxyConfigService;
-class ProxyService;
-class URLRequestContextStorage;
 }
 
 namespace headless {

diff --git a/headless/lib/browser/headless_web_contents_impl.h b/headless/lib/browser/headless_web_contents_impl.h
@@ -20,7 +20,6 @@ class Window;
 }
 
 namespace content {
-class BrowserContext;
 class DevToolsAgentHost;
 class WebContents;
 }
@@ -30,7 +29,6 @@ class Size;
 }
 
 namespace headless {
-class HeadlessDevToolsHostImpl;
 class HeadlessBrowserImpl;
 class WebContentsObserverAdapter;
 

diff --git a/headless/lib/headless_content_main_delegate.h b/headless/lib/headless_content_main_delegate.h
@@ -12,10 +12,6 @@
 #include "content/public/app/content_main_delegate.h"
 #include "headless/lib/headless_content_client.h"
 
-namespace content {
-class BrowserContext;
-}
-
 namespace headless {
 
 class HeadlessBrowserImpl;

diff --git a/headless/public/util/deterministic_http_protocol_handler.h b/headless/public/util/deterministic_http_protocol_handler.h
@@ -17,7 +17,6 @@ class URLRequestJobFactory;
 
 namespace headless {
 class DeterministicDispatcher;
-class HeadlessBrowserContext;
 
 // A deterministic protocol handler.  Requests made to this protocol handler
 // will return in order of creation, regardless of what order the network

diff --git a/headless/public/util/http_url_fetcher.h b/headless/public/util/http_url_fetcher.h
@@ -10,7 +10,6 @@
 
 namespace net {
 class URLRequestContext;
-class URLRequestJobFactory;
 }  // namespace
 
 namespace headless {

diff --git a/headless/public/util/in_memory_request_job.h b/headless/public/util/in_memory_request_job.h
@@ -9,11 +9,6 @@
 #include "headless/public/util/in_memory_protocol_handler.h"
 #include "net/url_request/url_request_job.h"
 
-namespace net {
-class StringIOBuffer;
-class DrainableIOBuffer;
-}
-
 namespace headless {
 class InMemoryRequestJob : public net::URLRequestJob {
  public:

diff --git a/headless/public/util/testing/generic_url_request_mocks.h b/headless/public/util/testing/generic_url_request_mocks.h
@@ -16,14 +16,6 @@
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_job_factory.h"
 
-namespace net {
-class URLRequestJob;
-}  // namespace net
-
-namespace htmlrender_webkit_headless_proto {
-class Resource;
-}  // htmlrender_webkit_headless_proto net
-
 namespace headless {
 
 class MockGenericURLRequestJobDelegate : public GenericURLRequestJob::Delegate {

diff --git a/ipc/handle_win.h b/ipc/handle_win.h
@@ -19,8 +19,6 @@ class PickleIterator;
 
 namespace IPC {
 
-class Message;
-
 // HandleWin is a wrapper around a Windows HANDLE that can be transported
 // across Chrome IPC channels that support attachment brokering. The HANDLE will
 // be duplicated into the destination process.

diff --git a/ipc/ipc_channel_nacl.h b/ipc/ipc_channel_nacl.h
@@ -19,6 +19,8 @@
 
 namespace IPC {
 
+class MessageAttachment;
+
 // Contains the results from one call to imc_recvmsg (data and file
 // descriptors).
 struct MessageContents;

diff --git a/ipc/ipc_channel_proxy.h b/ipc/ipc_channel_proxy.h
@@ -34,7 +34,6 @@ namespace IPC {
 class ChannelFactory;
 class MessageFilter;
 class MessageFilterRouter;
-class SendCallbackHelper;
 
 //-----------------------------------------------------------------------------
 // IPC::ChannelProxy

diff --git a/ipc/ipc_message.h b/ipc/ipc_message.h
@@ -30,7 +30,6 @@ class ChannelReader;
 //------------------------------------------------------------------------------
 
 struct LogData;
-class MessageAttachment;
 class MessageAttachmentSet;
 
 class IPC_EXPORT Message : public base::Pickle {

diff --git a/ipc/ipc_message_pipe_reader.h b/ipc/ipc_message_pipe_reader.h
@@ -26,8 +26,6 @@
 namespace IPC {
 namespace internal {
 
-class AsyncHandleWaiter;
-
 // A helper class to handle bytestream directly over mojo::MessagePipe
 // in template-method pattern. MessagePipeReader manages the lifetime
 // of given MessagePipe and participates the event loop, and

diff --git a/jingle/notifier/communicator/login.h b/jingle/notifier/communicator/login.h
@@ -21,7 +21,6 @@
 #include "webrtc/libjingle/xmpp/xmppengine.h"
 
 namespace buzz {
-class XmppClient;
 class XmppClientSettings;
 class XmppTaskParentInterface;
 }  // namespace buzz

diff --git a/mojo/edk/system/data_pipe_consumer_dispatcher.h b/mojo/edk/system/data_pipe_consumer_dispatcher.h
@@ -24,7 +24,6 @@
 namespace mojo {
 namespace edk {
 
-struct DataPipeControlMessage;
 class NodeController;
 
 // This is the Dispatcher implementation for the consumer handle for data

diff --git a/mojo/edk/system/data_pipe_control_message.h b/mojo/edk/system/data_pipe_control_message.h
@@ -17,7 +17,6 @@ namespace mojo {
 namespace edk {
 
 class NodeController;
-class PortsMessage;
 
 enum DataPipeCommand : uint32_t {
   // Signal to the consumer that new data is available.

diff --git a/mojo/edk/system/message_pipe_dispatcher.h b/mojo/edk/system/message_pipe_dispatcher.h
@@ -21,7 +21,6 @@ namespace mojo {
 namespace edk {
 
 class NodeController;
-class PortsMessage;
 
 class MessagePipeDispatcher : public Dispatcher {
  public:

diff --git a/mojo/edk/system/shared_buffer_dispatcher.h b/mojo/edk/system/shared_buffer_dispatcher.h
@@ -21,7 +21,6 @@ namespace mojo {
 
 namespace edk {
 class NodeController;
-class PlatformSupport;
 
 class MOJO_SYSTEM_IMPL_EXPORT SharedBufferDispatcher final : public Dispatcher {
  public: