Small improvements of header inclusion for ws/display.h

This CL removes some inclusions of ws/display.h that are actually not necessary or can just be replaced with a pre-declaration of ws::Display. BUG=None Review-Url: https://codereview.chromium.org/2679643002 Cr-Commit-Position: refs/heads/master@{#448289}
hylschwy · Feb 6, 2017 · dac8ee8 · dac8ee8
1 parent be2836e
commit dac8ee8
Show file tree

Hide file tree

Showing 7 changed files with 5 additions and 4 deletions.
diff --git a/services/ui/service.cc b/services/ui/service.cc
@@ -29,7 +29,6 @@
 #include "services/ui/ime/ime_registrar_impl.h"
 #include "services/ui/ime/ime_server_impl.h"
 #include "services/ui/ws/accessibility_manager.h"
-#include "services/ui/ws/display.h"
 #include "services/ui/ws/display_binding.h"
 #include "services/ui/ws/display_manager.h"
 #include "services/ui/ws/gpu_host.h"

diff --git a/services/ui/ws/display_binding.h b/services/ui/ws/display_binding.h
@@ -10,12 +10,12 @@
 #include "base/macros.h"
 #include "mojo/public/cpp/bindings/binding.h"
 #include "services/ui/public/interfaces/window_tree_host.mojom.h"
-#include "services/ui/ws/display.h"
 #include "services/ui/ws/user_id.h"
 
 namespace ui {
 namespace ws {
 
+class Display;
 class ServerWindow;
 class WindowServer;
 class WindowTree;

diff --git a/services/ui/ws/event_dispatcher.cc b/services/ui/ws/event_dispatcher.cc
@@ -9,7 +9,6 @@
 #include "base/memory/ptr_util.h"
 #include "base/time/time.h"
 #include "services/ui/ws/accelerator.h"
-#include "services/ui/ws/display.h"
 #include "services/ui/ws/drag_controller.h"
 #include "services/ui/ws/drag_source.h"
 #include "services/ui/ws/event_dispatcher_delegate.h"

diff --git a/services/ui/ws/window_manager_display_root.cc b/services/ui/ws/window_manager_display_root.cc
@@ -4,6 +4,7 @@
 
 #include "services/ui/ws/window_manager_display_root.h"
 
+#include "services/ui/ws/display.h"
 #include "services/ui/ws/display_manager.h"
 #include "services/ui/ws/server_window.h"
 #include "services/ui/ws/window_server.h"

diff --git a/services/ui/ws/window_manager_state.cc b/services/ui/ws/window_manager_state.cc
@@ -10,6 +10,7 @@
 #include "services/service_manager/public/interfaces/connector.mojom.h"
 #include "services/ui/common/accelerator_util.h"
 #include "services/ui/ws/accelerator.h"
+#include "services/ui/ws/display.h"
 #include "services/ui/ws/display_manager.h"
 #include "services/ui/ws/platform_display.h"
 #include "services/ui/ws/server_window.h"

diff --git a/services/ui/ws/window_manager_state.h b/services/ui/ws/window_manager_state.h
@@ -24,6 +24,7 @@ namespace ui {
 namespace ws {
 
 class DisplayManager;
+class PlatformDisplay;
 class WindowManagerDisplayRoot;
 class WindowTree;
 

diff --git a/services/ui/ws/window_server.h b/services/ui/ws/window_server.h
@@ -18,7 +18,6 @@
 #include "mojo/public/cpp/bindings/binding.h"
 #include "services/ui/public/interfaces/window_manager_window_tree_factory.mojom.h"
 #include "services/ui/public/interfaces/window_tree.mojom.h"
-#include "services/ui/ws/display.h"
 #include "services/ui/ws/gpu_host_delegate.h"
 #include "services/ui/ws/ids.h"
 #include "services/ui/ws/operation.h"
@@ -33,6 +32,7 @@ namespace ui {
 namespace ws {
 
 class AccessPolicy;
+class Display;
 class DisplayManager;
 class GpuHost;
 class ServerWindow;