Skip to content

Commit

Permalink
Add some additional help to the .gn file.
Browse files Browse the repository at this point in the history
I started to define a flag in terms of is_ios and was initially surprised that
this did not work. This patch adds some help describing this problem and how to
solve it.

BUG=

Review-Url: https://codereview.chromium.org/2656173002
Cr-Commit-Position: refs/heads/master@{#448917}
  • Loading branch information
brettw authored and Commit bot committed Feb 8, 2017
1 parent 940efb9 commit d8a46d9
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions .gn
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@ secondary_source = "//build/secondary/"
# being built as part of Chrome vs. being built standalone. In this case, the
# Chrome defaults should go here. There should be no overrides here for
# values declared in the main Chrome repository.
#
# Important note for defining defaults: This file is executed before the
# BUILDCONFIG.gn file. That file sets up the global variables like "is_ios".
# This means that the default_args can not depend on the platform,
# architecture, or other build parameters. If you really need that, the other
# repo should define a flag that toggles on a behavior that implements the
# additional logic required by Chrome to set the variables.
default_args = {
v8_extra_library_files = [
# Dependencies used by the extra libraries. Putting them here causes them
Expand Down

0 comments on commit d8a46d9

Please sign in to comment.