Revert of [DevTools] Consolidate overlay-related functionality in Ove…

…rlay domain (patchset chromium#7 id:120001 of https://codereview.chromium.org/2819183002/ ) Reason for revert: This seems to be breaking the devtools closure compiler, i.e., closure is reporting an error: https://luci-milo.appspot.com/buildbot/chromium.linux/Linux%20Tests/55326 https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FLinux_Tests%2F55326%2F%2B%2Frecipes%2Fsteps%2Fdevtools_closure_compile%2F0%2Fstdout Command: /usr/bin/python ../../testing/scripts/run_devtools_check.py ../../third_party/WebKit/Source/devtools/scripts/compile_frontend.py --isolated-script-test-output=/b/s/w/ioH2ERuI/output.json --isolated-script-test-chartjson-output=/b/s/w/ioH2ERuI/chartjson-output.json Java executable: /usr/bin/java Compiling frontend... Compiling devtools_compatibility.js... Verifying JSDoc comments... devtools_compatibility.js compilation output: 0 error(s), 0 warning(s), 95.2% typed devtools frontend compilation output: /b/s/w/itFkGMoq/tmp_x1qK7/front_end/emulation/DeviceModeModel.js:640: WARNING - Property renderingAgent never defined on SDK.Target this._target.renderingAgent().setShowViewportSizeOnResize(false); ^^^^^^^^^^^^^^ 0 error(s), 1 warning(s), 94.3% typed ERRORS DETECTED Running ['/usr/bin/python', '../../third_party/WebKit/Source/devtools/scripts/compile_frontend.py'] in None (env: None) Command ['/usr/bin/python', '../../third_party/WebKit/Source/devtools/scripts/compile_frontend.py'] returned exit code 1 Original issue's description: > [DevTools] Consolidate overlay-related functionality in Overlay domain > > This turns InspectorOverlay into InspectorOverlayAgent with respective > lifetime and domain: > - rendering domain merges into overlay; > - Page.configureOverlay moves to overlay; > - highlighting and inspect mode move from DOM to overlay. > > BUG=none > TBR=skyostil@chromium.org > > Review-Url: https://codereview.chromium.org/2819183002 > Cr-Original-Original-Commit-Position: refs/heads/master@{#465422} > Committed: https://chromium.googlesource.com/chromium/src/+/8982f602a8e1f521949d8dd8dae58cff1c787bec > Review-Url: https://codereview.chromium.org/2819183002 > Cr-Original-Commit-Position: refs/heads/master@{#465812} > Committed: https://chromium.googlesource.com/chromium/src/+/7afbb9a64fbd30254a2dab9a689648621fa29f14 > Review-Url: https://codereview.chromium.org/2819183002 > Cr-Commit-Position: refs/heads/master@{#466489} > Committed: https://chromium.googlesource.com/chromium/src/+/c8abe8c3b07d77195777e07180a4122f4d50246a TBR=pfeldman@chromium.org,skyostil@chromium.org,dgozman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=none Review-Url: https://codereview.chromium.org/2835843002 Cr-Commit-Position: refs/heads/master@{#466557}
hylschwy · Apr 23, 2017 · c1bc835 · c1bc835
1 parent 8b1af15
commit c1bc835
Show file tree

Hide file tree

Showing 63 changed files with 1,353 additions and 1,296 deletions.
diff --git a/content/browser/devtools/protocol/schema_handler.cc b/content/browser/devtools/protocol/schema_handler.cc
@@ -22,37 +22,14 @@ Response SchemaHandler::GetDomains(
     std::unique_ptr<protocol::Array<Schema::Domain>>* domains) {
   // TODO(kozyatisnkiy): get this from the target instead of hardcoding a list.
   static const char kVersion[] = "1.2";
-  static const char* kDomains[] = {"Inspector",
-                                   "Memory",
-                                   "Page",
-                                   "Emulation",
-                                   "Security",
-                                   "Network",
-                                   "Database",
-                                   "IndexedDB",
-                                   "CacheStorage",
-                                   "DOMStorage",
-                                   "CSS",
-                                   "ApplicationCache",
-                                   "DOM",
-                                   "IO",
-                                   "DOMDebugger",
-                                   "ServiceWorker",
-                                   "Input",
-                                   "LayerTree",
-                                   "DeviceOrientation",
-                                   "Tracing",
-                                   "Animation",
-                                   "Accessibility",
-                                   "Storage",
-                                   "Log",
-                                   "Runtime",
-                                   "Debugger",
-                                   "Profiler",
-                                   "HeapProfiler",
-                                   "Schema",
-                                   "Target",
-                                   "Overlay"};
+  static const char* kDomains[] = {
+    "Inspector", "Memory", "Page", "Rendering", "Emulation", "Security",
+    "Network", "Database", "IndexedDB", "CacheStorage", "DOMStorage", "CSS",
+    "ApplicationCache", "DOM", "IO", "DOMDebugger", "ServiceWorker",
+    "Input", "LayerTree", "DeviceOrientation", "Tracing", "Animation",
+    "Accessibility", "Storage", "Log", "Runtime", "Debugger",
+    "Profiler", "HeapProfiler", "Schema", "Target"
+  };
   *domains = protocol::Array<Schema::Domain>::create();
   for (size_t i = 0; i < arraysize(kDomains); ++i) {
     (*domains)->addItem(Schema::Domain::Create()

diff --git a/headless/BUILD.gn b/headless/BUILD.gn
@@ -146,6 +146,7 @@ devtools_domains = [
   "network",
   "page",
   "profiler",
+  "rendering",
   "runtime",
   "security",
   "service_worker",

diff --git a/headless/lib/browser/headless_devtools_client_impl.cc b/headless/lib/browser/headless_devtools_client_impl.cc
@@ -59,6 +59,7 @@ HeadlessDevToolsClientImpl::HeadlessDevToolsClientImpl()
       network_domain_(this),
       page_domain_(this),
       profiler_domain_(this),
+      rendering_domain_(this),
       runtime_domain_(this),
       security_domain_(this),
       service_worker_domain_(this),
@@ -328,6 +329,10 @@ profiler::Domain* HeadlessDevToolsClientImpl::GetProfiler() {
   return &profiler_domain_;
 }
 
+rendering::Domain* HeadlessDevToolsClientImpl::GetRendering() {
+  return &rendering_domain_;
+}
+
 runtime::Domain* HeadlessDevToolsClientImpl::GetRuntime() {
   return &runtime_domain_;
 }

diff --git a/headless/lib/browser/headless_devtools_client_impl.h b/headless/lib/browser/headless_devtools_client_impl.h
@@ -34,6 +34,7 @@
 #include "headless/public/devtools/domains/network.h"
 #include "headless/public/devtools/domains/page.h"
 #include "headless/public/devtools/domains/profiler.h"
+#include "headless/public/devtools/domains/rendering.h"
 #include "headless/public/devtools/domains/runtime.h"
 #include "headless/public/devtools/domains/security.h"
 #include "headless/public/devtools/domains/service_worker.h"
@@ -86,6 +87,7 @@ class HeadlessDevToolsClientImpl : public HeadlessDevToolsClient,
   network::Domain* GetNetwork() override;
   page::Domain* GetPage() override;
   profiler::Domain* GetProfiler() override;
+  rendering::Domain* GetRendering() override;
   runtime::Domain* GetRuntime() override;
   security::Domain* GetSecurity() override;
   service_worker::Domain* GetServiceWorker() override;
@@ -188,6 +190,7 @@ class HeadlessDevToolsClientImpl : public HeadlessDevToolsClient,
   network::ExperimentalDomain network_domain_;
   page::ExperimentalDomain page_domain_;
   profiler::ExperimentalDomain profiler_domain_;
+  rendering::ExperimentalDomain rendering_domain_;
   runtime::ExperimentalDomain runtime_domain_;
   security::ExperimentalDomain security_domain_;
   service_worker::ExperimentalDomain service_worker_domain_;

diff --git a/headless/public/headless_devtools_client.h b/headless/public/headless_devtools_client.h
@@ -84,6 +84,9 @@ class Domain;
 namespace profiler {
 class Domain;
 }
+namespace rendering {
+class Domain;
+}
 namespace runtime {
 class Domain;
 }
@@ -136,6 +139,7 @@ class HEADLESS_EXPORT HeadlessDevToolsClient {
   virtual network::Domain* GetNetwork() = 0;
   virtual page::Domain* GetPage() = 0;
   virtual profiler::Domain* GetProfiler() = 0;
+  virtual rendering::Domain* GetRendering() = 0;
   virtual runtime::Domain* GetRuntime() = 0;
   virtual security::Domain* GetSecurity() = 0;
   virtual service_worker::Domain* GetServiceWorker() = 0;

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js
@@ -967,7 +967,7 @@ InspectorTest.dumpInspectorHighlightJSON = function(idValue, callback)
 
     function nodeResolved(node)
     {
-        InspectorTest.OverlayAgent.getHighlightObjectForTest(node.id, report);
+        InspectorTest.DOMAgent.getHighlightObjectForTest(node.id, report);
     }
 
     function report(error, result)

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
@@ -978,7 +978,6 @@ SDK.targetManager.observeTargets({
         InspectorTest.HeapProfilerAgent = target.heapProfilerAgent();
         InspectorTest.InspectorAgent = target.inspectorAgent();
         InspectorTest.NetworkAgent = target.networkAgent();
-        InspectorTest.OverlayAgent = target.overlayAgent();
         InspectorTest.PageAgent = target.pageAgent();
         InspectorTest.ProfilerAgent = target.profilerAgent();
         InspectorTest.RuntimeAgent = target.runtimeAgent();
@@ -993,7 +992,6 @@ SDK.targetManager.observeTargets({
         InspectorTest.domDebuggerModel = target.model(SDK.DOMDebuggerModel);
         InspectorTest.cssModel = target.model(SDK.CSSModel);
         InspectorTest.cpuProfilerModel = target.model(SDK.CPUProfilerModel);
-        InspectorTest.overlayModel = target.model(SDK.OverlayModel);
         InspectorTest.serviceWorkerManager = target.model(SDK.ServiceWorkerManager);
         InspectorTest.tracingManager = target.model(SDK.TracingManager);
         InspectorTest.mainTarget = target;

diff --git a/third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-setInspectModeEnabled.html b/third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-setInspectModeEnabled.html
@@ -7,10 +7,9 @@
 {
     var nodeInfo = {};
     InspectorTest.eventHandler["DOM.setChildNodes"] = setChildNodes;
-    InspectorTest.eventHandler["Overlay.inspectNodeRequested"] = inspectNodeRequested;
+    InspectorTest.eventHandler["DOM.inspectNodeRequested"] = inspectNodeRequested;
     InspectorTest.sendCommand("DOM.enable", {});
-    InspectorTest.sendCommand("Overlay.enable", {});
-    InspectorTest.sendCommand("Overlay.setInspectMode", { "mode": "searchForNode", highlightConfig: {} }, onSetModeEnabled);
+    InspectorTest.sendCommand("DOM.setInspectMode", { "mode": "searchForNode", highlightConfig: {} }, onSetModeEnabled);
 
     function onSetModeEnabled(message)
     {

diff --git a/third_party/WebKit/LayoutTests/inspector/agents-enable-disable-expected.txt b/third_party/WebKit/LayoutTests/inspector/agents-enable-disable-expected.txt
@@ -11,7 +11,6 @@ IndexedDB.disable finished successfully
 LayerTree.disable finished successfully
 Log.disable finished successfully
 Network.disable finished successfully
-Overlay.disable finished successfully
 Page.disable finished successfully
 Profiler.disable finished successfully
 Runtime.disable finished successfully
@@ -49,9 +48,6 @@ Log.disable finished successfully
 Network.enable finished successfully
 Network.disable finished successfully
 
-Overlay.enable finished with error DOM should be enabled first
-Overlay.disable finished successfully
-
 Page.enable finished successfully
 Page.disable finished successfully
 

diff --git a/third_party/WebKit/LayoutTests/inspector/elements/inspect-mode-after-profiling.html b/third_party/WebKit/LayoutTests/inspector/elements/inspect-mode-after-profiling.html
@@ -18,7 +18,7 @@
 {
     InspectorTest.cpuProfilerModel.startRecording();
     InspectorTest.cpuProfilerModel.stopRecording();
-    InspectorTest.overlayModel.setInspectMode(Protocol.Overlay.InspectMode.SearchForNode).then(clickAtInspected);
+    InspectorTest.domModel.setInspectMode(Protocol.DOM.InspectMode.SearchForNode, clickAtInspected);
 
     function clickAtInspected()
     {

diff --git a/third_party/WebKit/LayoutTests/inspector/elements/inspect-mode-shadow-text.html b/third_party/WebKit/LayoutTests/inspector/elements/inspect-mode-shadow-text.html
@@ -19,7 +19,7 @@
 
 function test()
 {
-    InspectorTest.overlayModel.setInspectMode(Protocol.Overlay.InspectMode.SearchForNode).then(step2);
+    InspectorTest.domModel.setInspectMode(Protocol.DOM.InspectMode.SearchForNode, step2);
 
     function step2()
     {

diff --git a/third_party/WebKit/LayoutTests/inspector/elements/inspect-pointer-events-none.html b/third_party/WebKit/LayoutTests/inspector/elements/inspect-pointer-events-none.html
@@ -59,7 +59,7 @@
 
     function step1()
     {
-        InspectorTest.overlayModel.setInspectMode(Protocol.Overlay.InspectMode.SearchForNode).then(step2);
+        InspectorTest.domModel.setInspectMode(Protocol.DOM.InspectMode.SearchForNode, step2);
     }
 
     function step2()
@@ -72,7 +72,7 @@
     {
         InspectorTest.firstElementsTreeOutline().removeEventListener(Elements.ElementsTreeOutline.Events.SelectedNodeChanged, step3);
         expectSelectedNode("inner");
-        InspectorTest.overlayModel.setInspectMode(Protocol.Overlay.InspectMode.SearchForNode).then(step4);
+        InspectorTest.domModel.setInspectMode(Protocol.DOM.InspectMode.SearchForNode, step4);
     }
 
     function step4()

diff --git a/third_party/WebKit/LayoutTests/inspector/elements/inspect-pseudo-element.html b/third_party/WebKit/LayoutTests/inspector/elements/inspect-pseudo-element.html
@@ -16,7 +16,7 @@
 
 function test()
 {
-    InspectorTest.overlayModel.setInspectMode(Protocol.Overlay.InspectMode.SearchForNode).then(inspectModeEnabled);
+    InspectorTest.domModel.setInspectMode(Protocol.DOM.InspectMode.SearchForNode, inspectModeEnabled);
 
     function inspectModeEnabled()
     {

diff --git a/third_party/WebKit/LayoutTests/inspector/layers/no-overlay-layers.html b/third_party/WebKit/LayoutTests/inspector/layers/no-overlay-layers.html
@@ -25,7 +25,7 @@
     {
         // Assure layer objects are not re-created during updates.
         InspectorTest.layerTreeModel().layerTree().forEachLayer(function(layer) { layersBeforeHighlight.push(layer.id()); });
-        InspectorTest.OverlayAgent.highlightRect(0, 0, 200, 200, {r:255, g:0, b:0});
+        InspectorTest.DOMAgent.highlightRect(0, 0, 200, 200, {r:255, g:0, b:0});
         InspectorTest.evaluateAndRunWhenTreeChanges("requestAnimationFrame(updateGeometry)", step2);
     }
 

diff --git a/third_party/WebKit/LayoutTests/inspector/profiler/agents-disabled-check-expected.txt b/third_party/WebKit/LayoutTests/inspector/profiler/agents-disabled-check-expected.txt
@@ -1,22 +1,22 @@
 Test that if a profiler is working all the agents are disabled.
 
 --> SDK.targetManager.suspendAllTargets();
+frontend: {"id":<number>,"method":"Page.configureOverlay","params":{"suspended":true}}
 frontend: {"id":<number>,"method":"Target.setAutoAttach","params":{"autoAttach":true,"waitForDebuggerOnStart":false}}
 frontend: {"id":<number>,"method":"Debugger.disable"}
 frontend: {"id":<number>,"method":"Debugger.setAsyncCallStackDepth","params":{"maxDepth":0}}
-frontend: {"id":<number>,"method":"Overlay.setPausedInDebuggerMessage"}
+frontend: {"id":<number>,"method":"Page.configureOverlay","params":{"suspended":true}}
 frontend: {"id":<number>,"method":"DOM.disable"}
 frontend: {"id":<number>,"method":"CSS.disable"}
-frontend: {"id":<number>,"method":"Overlay.setSuspended","params":{"suspended":true}}
 
 --> SDK.targetManager.resumeAllTargets();
+frontend: {"id":<number>,"method":"Page.configureOverlay","params":{"suspended":false}}
 frontend: {"id":<number>,"method":"Target.setAutoAttach","params":{"autoAttach":true,"waitForDebuggerOnStart":true}}
 frontend: {"id":<number>,"method":"Debugger.enable"}
 frontend: {"id":<number>,"method":"Debugger.setPauseOnExceptions","params":{"state":"none"}}
 frontend: {"id":<number>,"method":"Debugger.setAsyncCallStackDepth","params":{"maxDepth":8}}
 frontend: {"id":<number>,"method":"DOM.enable"}
 frontend: {"id":<number>,"method":"CSS.enable"}
-frontend: {"id":<number>,"method":"Overlay.setSuspended","params":{"suspended":false}}
 
 --> done
 
diff --git a/third_party/WebKit/Source/core/inspector/BUILD.gn b/third_party/WebKit/Source/core/inspector/BUILD.gn
@@ -148,12 +148,12 @@ inspector_protocol_generate("protocol_sources") {
     "inspector/protocol/Memory.h",
     "inspector/protocol/Network.cpp",
     "inspector/protocol/Network.h",
-    "inspector/protocol/Overlay.cpp",
-    "inspector/protocol/Overlay.h",
     "inspector/protocol/Page.cpp",
     "inspector/protocol/Page.h",
     "inspector/protocol/Protocol.cpp",
     "inspector/protocol/Protocol.h",
+    "inspector/protocol/Rendering.cpp",
+    "inspector/protocol/Rendering.h",
     "inspector/protocol/Runtime.h",
     "inspector/protocol/Security.cpp",
     "inspector/protocol/Security.h",