Skip to content

Commit

Permalink
[Android Log] Move Presubmit checks to upload time only
Browse files Browse the repository at this point in the history
They are intended to be FYI checks. If they are ignored at upload
time, submitting should still work.

BUG=

Review URL: https://codereview.chromium.org/1147103002

Cr-Commit-Position: refs/heads/master@{#330922}
  • Loading branch information
dgn authored and Commit bot committed May 21, 2015
1 parent 69a7e01 commit bbbc31f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion PRESUBMIT.py
Original file line number Diff line number Diff line change
Expand Up @@ -1497,7 +1497,6 @@ def _CommonChecks(input_api, output_api):
results.extend(_CheckForCopyrightedCode(input_api, output_api))
results.extend(_CheckForWindowsLineEndings(input_api, output_api))
results.extend(_CheckSingletonInHeaders(input_api, output_api))
results.extend(_CheckNoNewUtilLogUsage(input_api, output_api))

if any('PRESUBMIT.py' == f.LocalPath() for f in input_api.AffectedFiles()):
results.extend(input_api.canned_checks.RunUnitTestsInDirectory(
Expand Down Expand Up @@ -1725,6 +1724,7 @@ def CheckChangeOnUpload(input_api, output_api):
results.extend(
input_api.canned_checks.CheckGNFormatted(input_api, output_api))
results.extend(_CheckUmaHistogramChanges(input_api, output_api))
results.extend(_CheckNoNewUtilLogUsage(input_api, output_api))
return results


Expand Down

0 comments on commit bbbc31f

Please sign in to comment.