Skip to content

Commit

Permalink
Migrate LaunchUnitTests callers to OnceCallback
Browse files Browse the repository at this point in the history
This updates callers of base::LaunchUnitTests in several directory
to use base::OnceCallback instead of legacy base::Callback.
No intended functional change is included.

This reduces the number of 'base::Bind' in //gin, //notification_helper,
//pdf, //sql, //url, and //chrome_elf from 7 to 0 as tracked at
http://goo.gl/LUVhDj

Bug: 714018
Change-Id: Ie1bf3ad1ca90f732356d4612cfd8e3e8eca8afda
Reviewed-on: https://chromium-review.googlesource.com/954882
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542743}
  • Loading branch information
tzik authored and Commit Bot committed Mar 13, 2018
1 parent 02472a2 commit 91bae81
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 7 deletions.
4 changes: 2 additions & 2 deletions gin/test/run_all_unittests.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ int main(int argc, char** argv) {
base::TestSuite test_suite(argc, argv);

return base::LaunchUnitTests(
argc, argv, base::Bind(&base::TestSuite::Run,
base::Unretained(&test_suite)));
argc, argv,
base::BindOnce(&base::TestSuite::Run, base::Unretained(&test_suite)));
}
2 changes: 1 addition & 1 deletion pdf/run_all_unittests.cc
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ int main(int argc, char** argv) {
base::TestSuite test_suite(argc, argv);
return base::LaunchUnitTests(
argc, argv,
base::Bind(&base::TestSuite::Run, base::Unretained(&test_suite)));
base::BindOnce(&base::TestSuite::Run, base::Unretained(&test_suite)));
}
5 changes: 2 additions & 3 deletions sql/test/run_all_unittests.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ int main(int argc, char** argv) {
sql::SQLTestSuite test_suite(argc, argv);

return base::LaunchUnitTests(
argc,
argv,
base::Bind(&sql::SQLTestSuite::Run, base::Unretained(&test_suite)));
argc, argv,
base::BindOnce(&sql::SQLTestSuite::Run, base::Unretained(&test_suite)));
}
2 changes: 1 addition & 1 deletion url/run_all_unittests.cc
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@ int main(int argc, char** argv) {

return base::LaunchUnitTests(
argc, argv,
base::Bind(&base::TestSuite::Run, base::Unretained(&test_suite)));
base::BindOnce(&base::TestSuite::Run, base::Unretained(&test_suite)));
}

0 comments on commit 91bae81

Please sign in to comment.