Skip to content

Commit

Permalink
Disallow blink/public/common/ to depend back on blink/common/.
Browse files Browse the repository at this point in the history
The blink public API should not expose internal blink types outside
of blink. By disallowing this dependency by default we avoid
accidentally exposing those types.

Change-Id: I68883f3d7716b2309cadf32db8e5599d2fe5c8cb
Reviewed-on: https://chromium-review.googlesource.com/1028573
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553936}
  • Loading branch information
lucasgadani authored and Commit Bot committed Apr 26, 2018
1 parent d48e4a5 commit 9107ad3
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion third_party/blink/public/common/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,11 @@ include_rules = [
"+build",
"+net",
"+mojo",
"+third_party/blink/common",
"+third_party/blink/public/common",
"+third_party/blink/public/mojom",
"+url",

# This file should not be included outside of blink, so it does not belong
# in blink/public.
"+third_party/blink/common/common_export.h",
]

0 comments on commit 9107ad3

Please sign in to comment.