Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Disable unit tests for Window Manager Client in external window mode
After [1], no default display is created at the startup of the window server, making the following mus_ws_unitests hang: WindowServerTest.OnWindowHierarchyChangedIncludesTransientParent WindowServerTest.RootWindow WindowServerTest.Embed WindowServerTest.EmbeddedDoesntSeeChild WindowServerTest.SetBounds WindowServerTest.SetBoundsSecurity WindowServerTest.DestroySecurity WindowServerTest.MultiRoots WindowServerTest.Reorder WindowServerTest.Visible WindowServerTest.EmbedFailsWithChildren WindowServerTest.WindowServerDestroyedAfterRootObserver WindowServerTest.ClientAreaChanged WindowServerTest.EstablishConnectionViaFactory The issue is that WindowServerTestBase::SetUp is designed to wait until OnWmNewDisplay is called to be sure that a display (and root) is available, which never happens in external window mode. The above tests check WindowManagerClient and this class is not needed in external mode since the host system is always the window manager. Hence this CL disables these tests in external window mode, making mus_ws_unitests pass again on the corresponding platforms. [1] https://codereview.chromium.org/2697693002/ BUG=666958 Review-Url: https://codereview.chromium.org/2740123002 Cr-Commit-Position: refs/heads/master@{#455902}
- Loading branch information