Skip to content

Commit

Permalink
Temporarily disable VirtualKeyboardBrowserTest.IsKeyboardLoaded to la…
Browse files Browse the repository at this point in the history
…nd the V8 roll.

The current v8 roll breaks this test due to the activation of Object.observe.

BUG=370004
TBR=ishell@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/260903024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268173 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
machenbach@chromium.org committed May 5, 2014
1 parent ad2263f commit 7479c1e
Showing 1 changed file with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,13 @@ IN_PROC_BROWSER_TEST_F(VirtualKeyboardBrowserTest, KeysetTransitionTest) {
RunTest(base::FilePath(FILE_PATH_LITERAL("keyset_transition_test.js")));
}

IN_PROC_BROWSER_TEST_F(VirtualKeyboardBrowserTest, IsKeyboardLoaded) {
// Fails when enabling Object.observe. See http://crbug.com/370004
#if defined(OS_CHROMEOS)
#define MAYBE_IsKeyboardLoaded DISABLED_IsKeyboardLoaded
#else
#define MAYBE_IsKeyboardLoaded IsKeyboardLoaded
#endif
IN_PROC_BROWSER_TEST_F(VirtualKeyboardBrowserTest, MAYBE_IsKeyboardLoaded) {
content::RenderViewHost* keyboard_rvh = GetKeyboardRenderViewHost();
ASSERT_TRUE(keyboard_rvh);
bool loaded = false;
Expand Down

0 comments on commit 7479c1e

Please sign in to comment.