Skip to content

Commit

Permalink
Update DllHash to include recently blacklisted dlls
Browse files Browse the repository at this point in the history
BUG=

Review URL: https://codereview.chromium.org/353873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279814 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
csharp@chromium.org committed Jun 25, 2014
1 parent 0b5ec8b commit 6e72aaf
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
2 changes: 2 additions & 0 deletions chrome_elf/blacklist/blacklist.cc
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ namespace blacklist{
// For more information about how this list is generated, and how to get off
// of it, see:
// https://sites.google.com/a/chromium.org/dev/Home/third-party-developers
// NOTE: Please remember to update the DllHash enum in histograms.xml when
// adding a new value to the blacklist.
const wchar_t* g_troublesome_dlls[kTroublesomeDllsMaxCount] = {
L"activedetect32.dll", // Lenovo One Key Theater.
// See crbug.com/379218.
Expand Down
7 changes: 7 additions & 0 deletions tools/metrics/histograms/histograms.xml
Original file line number Diff line number Diff line change
Expand Up @@ -35907,9 +35907,16 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<enum name="DllHash" type="int">
<!-- Generated by chrome_elf/dll_hash_for_uma/dll_hash_for_uma_main.cc -->

<int value="272828651" label="activedetect64.dll"/>
<int value="750761702" label="systemk.dll"/>
<int value="777975221" label="activedetect32.dll"/>
<int value="803283353" label="lmrn.dll"/>
<int value="989714890" label="datamngr.dll"/>
<int value="1120295191" label="windowsapihookdll64.dll"/>
<int value="1148809156" label="chrmxtn.dll"/>
<int value="1270622879" label="hk.dll"/>
<int value="1409376135" label="windowsapihookdll32.dll"/>
<int value="1736709911" label="bitguard.dll"/>
<int value="2132270559" label="libsvn_tsvn32.dll"/>
</enum>

Expand Down

0 comments on commit 6e72aaf

Please sign in to comment.