Skip to content

Commit

Permalink
Add missing BUILD.gn dependencies and enable GN checks.
Browse files Browse the repository at this point in the history
Adds some missing dependencies in //third_party/webrtc_overrides, and
enables GN checks on that directory.

Bug: 812058
Change-Id: I23fc0f45887a2c9ab50c6d217c9fb2c327ec4e7e
Reviewed-on: https://chromium-review.googlesource.com/974755
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545101}
  • Loading branch information
Wez authored and Commit Bot committed Mar 22, 2018
1 parent 34a8f51 commit 51afb79
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .gn
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,8 @@ check_targets = [
"//third_party/snappy/*",

#"//third_party/WebKit/*", # Errors: https://crbug.com/800764
#"//third_party/webrtc/*",
"//third_party/webrtc_overrides/*",
"//tools/*",

"//ui/*",
Expand Down
8 changes: 8 additions & 0 deletions third_party/webrtc_overrides/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@ static_library("webrtc") {
"field_trial.cc",
"runtime_enabled_features.cc",
]
deps += [
"//base",
"//third_party/webrtc/system_wrappers:runtime_enabled_features_api",
]
}

configs += [
Expand Down Expand Up @@ -112,6 +116,9 @@ static_library("init_webrtc") {
]
deps = [
":task_queue_impl",
"//base",
"//third_party/webrtc/rtc_base",
"//third_party/webrtc/system_wrappers",
]
}

Expand Down Expand Up @@ -144,6 +151,7 @@ source_set("task_queue_impl") {
]
deps = [
"//base",
"//third_party/webrtc/rtc_base:refcount",
"//third_party/webrtc/rtc_base:rtc_task_queue_api",
]
}

0 comments on commit 51afb79

Please sign in to comment.