Skip to content

Commit

Permalink
[ios] Remove stack view perf test and unneeded TabSwitcherDelegate me…
Browse files Browse the repository at this point in the history
…thod.

This CL removes stack_view_controller_perftest, whose two tests have been disabled for a long
time. That test was the only code that used the TabSwitcherDelegate method
-tabSwitcherPresentationTransitionDidEnd:, which is also deleted.

Bug: 546328,717314
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5b4c923a1db1e0af435ec0aa284af82d415edef5
Reviewed-on: https://chromium-review.googlesource.com/914964
Reviewed-by: Menglu Huang <huangml@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536240}
  • Loading branch information
marcq authored and Commit Bot committed Feb 12, 2018
1 parent 32846d9 commit 4d1c216
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 447 deletions.
3 changes: 0 additions & 3 deletions ios/chrome/app/main_controller.mm
Original file line number Diff line number Diff line change
Expand Up @@ -2021,9 +2021,6 @@ - (void)finishDismissingStackView {
_dismissingStackView = NO;
}

- (void)tabSwitcherPresentationTransitionDidEnd:(id<TabSwitcher>)tabSwitcher {
}

- (id<ToolbarOwner>)tabSwitcherTransitionToolbarOwner {
// Request the view to ensure that the view has been loaded and initialized,
// since it may never have been loaded (or have been swapped out).
Expand Down
21 changes: 0 additions & 21 deletions ios/chrome/browser/ui/stack_view/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -134,24 +134,3 @@ source_set("eg_tests") {
]
libs = [ "XCTest.framework" ]
}

source_set("perf_tests") {
configs += [ "//build/config/compiler:enable_arc" ]
testonly = true
sources = [
"stack_view_controller_perftest.mm",
]
deps = [
":stack_view",
"//base",
"//base/test:test_support",
"//ios/chrome/browser/snapshots",
"//ios/chrome/browser/tabs",
"//ios/chrome/browser/test:perf_test_support",
"//ios/chrome/browser/ui",
"//ios/chrome/browser/ui:ui_internal",
"//ios/web",
"//net",
]
libs = [ "UIKit.framework" ]
}
1 change: 0 additions & 1 deletion ios/chrome/browser/ui/stack_view/stack_view_controller.mm
Original file line number Diff line number Diff line change
Expand Up @@ -1660,7 +1660,6 @@ - (void)notifyDelegatesTransitionFinished {
if (self.transitionStyle == STACK_TRANSITION_STYLE_PRESENTING) {
[_testDelegate stackViewControllerShowWithSelectedTabAnimationDidEnd];
[_animationDelegate tabSwitcherPresentationAnimationDidEnd:self];
[_delegate tabSwitcherPresentationTransitionDidEnd:self];
} else {
[_animationDelegate tabSwitcherDismissalAnimationDidEnd:self];
[_delegate tabSwitcherDismissTransitionDidEnd:self];
Expand Down
Loading

0 comments on commit 4d1c216

Please sign in to comment.