Skip to content

Commit

Permalink
Add instructions to HarfBuzz Readme on determining non-compiled files
Browse files Browse the repository at this point in the history
Bug: 870379
Tbr: eae, behdad
Change-Id: I89c78c4b5253706b5c8075576a53dd3791fcd4cf
Reviewed-on: https://chromium-review.googlesource.com/1162229
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582532}
  • Loading branch information
drott authored and Commit Bot committed Aug 13, 2018
1 parent 2847bc3 commit 48bbb36
Showing 1 changed file with 14 additions and 3 deletions.
17 changes: 14 additions & 3 deletions third_party/harfbuzz-ng/README.chromium
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,16 @@ API from the old one.

This copy of harfbuzz is updated by putting the new commit hash matching one in
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/ to the
top level DEPS file. When upgrading, check whether files have been added or
removed in upstream and whether the BUILD.gn file needs to be updated to reflect
that.
top level DEPS file. When upgrading, check in ther HarfBuzz repository whether
files have been added or removed in upstream and whether the BUILD.gn file needs
to be updated to reflect that or whether the files can be added to the exception
lis below.

Example:
$ cd ~/dev/harfbuzz/
$ git diff --diff-filter=A --stat 1.8.3..1.8.7

Replace 1.8.3 and 1.8.7 with the respective revision hashes for your roll CL.

Chromium-local cherry picks or patches can be done by pushing new branches to
refs/heads/chromium/ of [1]. The set of HarfBuzz OWNERS has write rights to this
Expand Down Expand Up @@ -46,9 +53,12 @@ Currently we are intentionally not building the following files from HarfBuzz.
hb-directwrite.cc
hb-directwrite.h
hb-fallback-shape.cc
hb-iter-private.hh
hb-machinery-private.hh
hb-map-private.hh
hb-map.cc
hb-map.h
hb-null.hh
hb-ot-color-sbix-table.hh
hb-ot-color-svg-table.hh
hb-ot-color.cc
Expand All @@ -58,4 +68,5 @@ Currently we are intentionally not building the following files from HarfBuzz.
hb-subset.cc
hb-uniscribe.cc
hb-uniscribe.h
hb-vector-private.hh
test-unicode-ranges.cc

0 comments on commit 48bbb36

Please sign in to comment.