Skip to content

Commit

Permalink
remove _p.c files to avoid link errors when incremental linking
Browse files Browse the repository at this point in the history
As far as I can tell, the _p.c files should only be included into a proxy when
calling across domains. When linking incrementally it appears those files
aren't dead-stripped which causes unresolved external references to
CStdStubBuffer_Release.

BUG=92175
TEST=no new functionality


Review URL: http://codereview.chromium.org/7599005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96669 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
scottmg@chromium.org committed Aug 13, 2011
1 parent e15b35a commit 48352a1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
3 changes: 1 addition & 2 deletions third_party/iaccessible2/iaccessible2.gyp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2010 The Chromium Authors. All rights reserved.
# Copyright (c) 2011 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

Expand All @@ -21,7 +21,6 @@
'ia2_api_all.idl',
'<(INTERMEDIATE_DIR)/ia2_api_all.h',
'<(INTERMEDIATE_DIR)/ia2_api_all_i.c',
'<(INTERMEDIATE_DIR)/ia2_api_all_p.c',
],
'hard_dependency': 1,
'direct_dependent_settings': {
Expand Down
5 changes: 1 addition & 4 deletions third_party/isimpledom/isimpledom.gyp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2010 The Chromium Authors. All rights reserved.
# Copyright (c) 2011 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

Expand All @@ -23,13 +23,10 @@
'ISimpleDOMText.idl',
'<(INTERMEDIATE_DIR)/ISimpleDOMDocument.h',
'<(INTERMEDIATE_DIR)/ISimpleDOMDocument_i.c',
'<(INTERMEDIATE_DIR)/ISimpleDOMDocument_p.c',
'<(INTERMEDIATE_DIR)/ISimpleDOMNode.h',
'<(INTERMEDIATE_DIR)/ISimpleDOMNode_i.c',
'<(INTERMEDIATE_DIR)/ISimpleDOMNode_p.c',
'<(INTERMEDIATE_DIR)/ISimpleDOMText.h',
'<(INTERMEDIATE_DIR)/ISimpleDOMText_i.c',
'<(INTERMEDIATE_DIR)/ISimpleDOMText_p.c',
],
'hard_dependency': 1,
'direct_dependent_settings': {
Expand Down

0 comments on commit 48352a1

Please sign in to comment.