Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Mark some in-product help actions as not user triggered.
Up until now, all actions related to in-product help have been considered directly triggered by the user, which is not necessarily the case, as some of them are more a by-product of other actions. This leads to in-product help being very prominent in some of helpful dashboards we have for these types of metrics, and it is swamping other entries. For now, the following in-product help actions are kept: * InProductHelp.Dismissed: * This is kept because it is in fact a user action to dismiss the in-product help. * InProductHelp.ShouldTriggerHelpUIResult.Triggered.IPH* * This is kept because it might very well impact what the user does next, since the UI will look different than for when it is not triggered. In addition, this happens very seldom, so the chances of this swamping the dashboards should be small. The following are marked as not_user_triggered: * InProductHelp.NotifyEvent.IPH* * This might be a user action, but if a feature cares about that, they should add their own specific action. * InProductHelp.ShouldTriggerHelpUI.IPH* * This is very often invoked, but is often a by-product of other actions. * InProductHelp.ShouldTriggerHelpUIResult.NotTriggered.IPH* * This is recorded around the same time as the ShouldTriggerHelpUI, and is also typically a by-product. * InProductHelp.ShouldTriggerHelpUIResult.WouldHaveTriggered.IPH* * This is recorded around the same time as the ShouldTriggerHelpUI, and is also typically a by-product. It is similar to the .Triggered version, but it does not have any effect on what the user sees. BUG=786102 Change-Id: I067d507470c79870e8627ecb1168584b862cf28b Reviewed-on: https://chromium-review.googlesource.com/1137026 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#578757}
- Loading branch information