Skip to content

Commit

Permalink
Mark some in-product help actions as not user triggered.
Browse files Browse the repository at this point in the history
Up until now, all actions related to in-product help have been
considered directly triggered by the user, which is not necessarily
the case, as some of them are more a by-product of other actions.

This leads to in-product help being very prominent in some of
helpful dashboards we have for these types of metrics, and it
is swamping other entries.

For now, the following in-product help actions are kept:
*   InProductHelp.Dismissed:
    *   This is kept because it is in fact a user action to dismiss
        the in-product help.
*   InProductHelp.ShouldTriggerHelpUIResult.Triggered.IPH*
    *   This is kept because it might very well impact what the user
        does next, since the UI will look different than for when it
        is not triggered. In addition, this happens very seldom, so
        the chances of this swamping the dashboards should be small.

The following are marked as not_user_triggered:
*   InProductHelp.NotifyEvent.IPH*
    *   This might be a user action, but if a feature cares about that,
        they should add their own specific action.
*   InProductHelp.ShouldTriggerHelpUI.IPH*
    *   This is very often invoked, but is often a by-product of other
        actions.
*   InProductHelp.ShouldTriggerHelpUIResult.NotTriggered.IPH*
    *   This is recorded around the same time as the
        ShouldTriggerHelpUI, and is also typically a by-product.
*   InProductHelp.ShouldTriggerHelpUIResult.WouldHaveTriggered.IPH*
    *   This is recorded around the same time as the
        ShouldTriggerHelpUI, and is also typically a by-product. It is
        similar to the .Triggered version, but it does not have any
        effect on what the user sees.

BUG=786102

Change-Id: I067d507470c79870e8627ecb1168584b862cf28b
Reviewed-on: https://chromium-review.googlesource.com/1137026
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578757}
  • Loading branch information
tommynyquist authored and Commit Bot committed Jul 27, 2018
1 parent aeee73e commit 4088d5c
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions tools/metrics/actions/actions.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5814,7 +5814,7 @@ should be able to be added at any place in this file.
<description>The user dismissed the in-product help.</description>
</action>

<action name="InProductHelp.NotifyEvent.IPH">
<action name="InProductHelp.NotifyEvent.IPH" not_user_triggered="true">
<owner>dtrainor@chromium.org</owner>
<owner>nyquist@chromium.org</owner>
<description>The user triggered an event in in-product help.</description>
Expand All @@ -5826,7 +5826,7 @@ should be able to be added at any place in this file.
<description>The user triggered a used event in in-product help.</description>
</action>

<action name="InProductHelp.ShouldTriggerHelpUI.IPH">
<action name="InProductHelp.ShouldTriggerHelpUI.IPH" not_user_triggered="true">
<owner>dtrainor@chromium.org</owner>
<owner>nyquist@chromium.org</owner>
<description>
Expand All @@ -5835,7 +5835,8 @@ should be able to be added at any place in this file.
</description>
</action>

<action name="InProductHelp.ShouldTriggerHelpUIResult.NotTriggered.IPH">
<action name="InProductHelp.ShouldTriggerHelpUIResult.NotTriggered.IPH"
not_user_triggered="true">
<owner>dtrainor@chromium.org</owner>
<owner>nyquist@chromium.org</owner>
<description>
Expand All @@ -5849,7 +5850,8 @@ should be able to be added at any place in this file.
<description>A user action triggered in-product help.</description>
</action>

<action name="InProductHelp.ShouldTriggerHelpUIResult.WouldHaveTriggered.IPH">
<action name="InProductHelp.ShouldTriggerHelpUIResult.WouldHaveTriggered.IPH"
not_user_triggered="true">
<owner>dtrainor@chromium.org</owner>
<owner>nyquist@chromium.org</owner>
<description>
Expand Down

0 comments on commit 4088d5c

Please sign in to comment.