build: Enable auto raw pointer deduction check everywhere on clang.

This patch enables the raw pointer deduction check on every platform.

R=danakj@chromium.org, thakis@chromium.org
BUG=554600

Review-Url: https://codereview.chromium.org/2723253003
Cr-Commit-Position: refs/heads/master@{#454453}

build/config/clang/BUILD.gn

@@ -35,18 +35,12 @@ config("find_bad_constructs") {
       "-add-plugin",
       "-Xclang",
       "find-bad-constructs",
+      "-Xclang",
+      "-plugin-arg-find-bad-constructs",
+      "-Xclang",
+      "check-auto-raw-pointer",
     ]
 
-    # TODO(vmpstr): We need to enable this everywhere. crbug.com/554600
-    if (is_linux && !is_chromeos && !is_chromecast) {
-      cflags += [
-        "-Xclang",
-        "-plugin-arg-find-bad-constructs",
-        "-Xclang",
-        "check-auto-raw-pointer",
-      ]
-    }
-
     if ((is_linux || is_android) && !is_chromecast) {
       cflags += [
         "-Xclang",

ios/chrome/browser/tabs/tab.mm

@@ -1397,7 +1397,7 @@ - (void)webWillFinishHistoryNavigationFromEntry:(CRWSessionEntry*)fromEntry {
 - (void)webState:(web::WebState*)webState
     didFinishNavigation:(web::NavigationContext*)navigation {
   if (navigation->IsSamePage()) {
-    auto faviconDriver = favicon::WebFaviconDriver::FromWebState(webState);
+    auto* faviconDriver = favicon::WebFaviconDriver::FromWebState(webState);
     if (faviconDriver) {
       // Fetch the favicon for the new URL.
       faviconDriver->FetchFavicon(navigation->GetUrl());

ios/chrome/browser/web/blocked_popup_tab_helper_unittest.mm

@@ -100,7 +100,7 @@ bool IsObservingSources() {
   EXPECT_FALSE(GetBlockedPopupTabHelper()->ShouldBlockPopup(source_url));
 
   // Verify that child window was open.
-  auto open_url_request = web_state_delegate_.last_open_url_request();
+  auto* open_url_request = web_state_delegate_.last_open_url_request();
   ASSERT_TRUE(open_url_request);
   EXPECT_EQ(web_state(), open_url_request->web_state);
   WebState::OpenURLParams params = open_url_request->params;