Skip to content

Commit

Permalink
Binary size tool: Don't escape text that won't be parsed.
Browse files Browse the repository at this point in the history
Only text that will be sent through an HTML parser needs to be parsed.
Escaping more than that results in & and < and similar in the
output.

R=andrewhayden@chromium.org

BUG=412708

Review URL: https://codereview.chromium.org/562623002

Cr-Commit-Position: refs/heads/master@{#294176}
  • Loading branch information
bratell-at-opera authored and Commit bot committed Sep 10, 2014
1 parent 8c2d278 commit 1dc8a92
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions tools/binary_size/template/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -133,19 +133,19 @@
cell.append('span').text(treemap.pathFor(record));
cell.append('br');
cell.append('span').text('Symbol: ');
cell.append('span').text(escape(record.n));
cell.append('span').text(record.n);
} else {
var href = 'https://code.google.com/p/chromium/codesearch#chromium/src'
+ treemap.pathFor(record)
+ '&q='
+ escape(record.n);
+ record.n;
cell.append('a')
.attr('href', href)
.attr('target', '_blank')
.text(escape(treemap.pathFor(record)));
.text(treemap.pathFor(record));
cell.append('br');
cell.append('span').text('Symbol: ');
cell.append('span').text(escape(record.n));
cell.append('span').text(record.n);
}
}
};
Expand Down Expand Up @@ -174,7 +174,7 @@
cell.append('a')
.attr('href', href)
.attr('target', '_blank')
.text(escape(treemap.pathFor(record)));
.text(treemap.pathFor(record));
}

}
Expand Down

0 comments on commit 1dc8a92

Please sign in to comment.