Skip to content

Commit

Permalink
Move json schema compiler target into build/ to match gyp
Browse files Browse the repository at this point in the history
ui/ and chrome/ should not depend on anything from //extensions.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/597713002

Cr-Commit-Position: refs/heads/master@{#297528}
  • Loading branch information
jamesr committed Sep 30, 2014
1 parent 9f98c0f commit 145636c
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
# The static library target also inherits the visibility and output_name
# of its invoker.

template("generated_extensions_api") {
template("json_schema_api") {
assert(defined(invoker.sources),
"\"sources\" must be defined for the $target_name template.")
assert(defined(invoker.root_namespace),
Expand Down
2 changes: 1 addition & 1 deletion build/json_schema_bundle_registration_compile.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
},
'actions': [
{
# GN version: //extensions/generated_extensions_api.gni
# GN version: json_schema_api.gni
'action_name': 'genapi_bundle_registration',
'inputs': [
'<@(generator_files)',
Expand Down
2 changes: 1 addition & 1 deletion build/json_schema_compile.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
},
'rules': [
{
# GN version: //extensions/generated_extensions_api.gni
# GN version: json_schema_api.gni
'rule_name': 'genapi',
'msvs_external_rule': 1,
'extension': 'json',
Expand Down
6 changes: 3 additions & 3 deletions chrome/common/extensions/api/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,19 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

import("//extensions/generated_extensions_api.gni")
import("//build/json_schema_api.gni")
import("schemas.gni")

# GYP version: chrome/common/extensions/api/api.gyp:chrome_api
generated_extensions_api("api") {
json_schema_api("api") {
schemas = true
bundle = true

deps = schema_dependencies
}

# GYP version: chrome/browser/extensions/api/api.gyp:chrome_api_registration
generated_extensions_api("api_registration") {
json_schema_api("api_registration") {
impl_dir = "//chrome/browser/extensions/api"
bundle_registration = true

Expand Down
6 changes: 3 additions & 3 deletions extensions/common/api/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,17 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

import("//extensions/generated_extensions_api.gni")
import("//build/json_schema_api.gni")
import("schemas.gni")

# GYP version: extensions/common/api/api.gyp:extensions_api
generated_extensions_api("api") {
json_schema_api("api") {
schemas = true
bundle = true
}

# GYP version: extensions/browser/api/api_registration.gyp:extensions_api_registration
generated_extensions_api("api_registration") {
json_schema_api("api_registration") {
impl_dir = "//extensions/browser/api"
bundle_registration = true

Expand Down
4 changes: 2 additions & 2 deletions ui/accessibility/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

import("//extensions/generated_extensions_api.gni")
import("//build/json_schema_api.gni")

component("accessibility") {
sources = [
Expand Down Expand Up @@ -71,7 +71,7 @@ test("accessibility_unittests") {
]
}

generated_extensions_api("ax_gen") {
json_schema_api("ax_gen") {
sources = [ "ax_enums.idl" ]
deps = [ "//base/third_party/dynamic_annotations" ]
root_namespace = "ui"
Expand Down

0 comments on commit 145636c

Please sign in to comment.