Skip to content

Commit

Permalink
Revert of Blacklists virtualCamera.ax (https://codereview.chromium.or…
Browse files Browse the repository at this point in the history
…g/325323003/)

Reason for revert:
No crashes have been found after 37.0.2046.2 and Canary on Windows is now on 37.0.2051.2, hence it looks good. Not sure if was the blacklisting or the "calling CoInitializeEx twice" patch which did the trick here.

I would like to revert the blacklisting patch to see if we can cope with the CoInitializeEx patch only. It would be great if we could avoid adding another DLL to the blacklist.

Original issue's description:
> Blacklists virtualCamera.ax.
> 
> Tries to avoid crash in media::CoreAudioUtil::CreateDeviceEnumerator by blacklisting a DLL which accounts for a large amount of crashes we see in CreateDeviceEnumerator.
> 
> BUG=383715, 378465
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276946

TBR=tommi@chromium.org,robertshield@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=383715, 378465

Review URL: https://codereview.chromium.org/335073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277320 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
henrika@chromium.org committed Jun 15, 2014
1 parent 70d8e45 commit 0431812
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions chrome_elf/blacklist/blacklist.cc
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@ const wchar_t* g_troublesome_dlls[kTroublesomeDllsMaxCount] = {
L"windowsapihookdll32.dll", // Lenovo One Key Theater.
L"activedetect64.dll", // Lenovo One Key Theater.
L"windowsapihookdll64.dll", // Lenovo One Key Theater.
L"virtualCamera.ax", // %PROGRAMFILES%\ASUS\VirtualCamera.
// See crbug.com/383715.
// Keep this null pointer here to mark the end of the list.
NULL,
};
Expand Down

0 comments on commit 0431812

Please sign in to comment.