Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 1, 2025

Bumps @rollup/plugin-node-resolve from 15.3.1 to 16.0.1.

Changelog

Sourced from @​rollup/plugin-node-resolve's changelog.

v16.0.1

2025-03-11

Bugfixes

  • fix: add ignoreSideEffectsForRoot to exported interface (#1841)

v16.0.0

2024-12-15

Breaking Changes

  • feat!: set development or production condition (#1823)
Commits
  • e1a5ef9 chore(release): node-resolve v16.0.1
  • d455fff fix(node-resolve): add ignoreSideEffectsForRoot to exported interface (#1841)
  • d64f8d6 chore(release): node-resolve v16.0.0
  • ebd0969 feat(node-resolve)!: set development or production condition (#1823)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 1, 2025

Assignees

The following users could not be added as assignees: hydro-project/maintainers. Either the username does not exist or it does not have the correct permissions to be added as an assignee.

Please fix the above issues or remove invalid values from dependabot.yml.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Sep 1, 2025
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/rollup/plugin-node-resolve-16.0.1 branch from d921fdc to ce48d5c Compare September 8, 2025 02:30
@jhellerstein
Copy link
Contributor

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 8, 2025

Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/rollup/plugin-node-resolve-16.0.1 branch from ce48d5c to 9b1e38a Compare September 8, 2025 14:55
Bumps [@rollup/plugin-node-resolve](https://github.com/rollup/plugins/tree/HEAD/packages/node-resolve) from 15.3.1 to 16.0.1.
- [Changelog](https://github.com/rollup/plugins/blob/master/packages/node-resolve/CHANGELOG.md)
- [Commits](https://github.com/rollup/plugins/commits/node-resolve-v16.0.1/packages/node-resolve)

---
updated-dependencies:
- dependency-name: "@rollup/plugin-node-resolve"
  dependency-version: 16.0.1
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/rollup/plugin-node-resolve-16.0.1 branch from 9b1e38a to 4d6a9c1 Compare September 16, 2025 03:06
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 6, 2025

Superseded by #35.

@dependabot dependabot bot closed this Oct 6, 2025
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/rollup/plugin-node-resolve-16.0.1 branch October 6, 2025 18:39
jhellerstein pushed a commit that referenced this pull request Oct 28, 2025
Addresses high-priority items from PR review:

1. PNG Export Implementation (Issue #1)
   - Replace fragile SVG serialization with html-to-image library
   - Add html-to-image@1.11.13 as production dependency
   - Properly handles CSS styles, fonts, and complex layouts
   - Uses 2x pixel ratio for better quality
   - Improved error handling with user-friendly messages

2. Memory Leak in Modal Creation (Issue #3)
   - Replace DOM manipulation with proper React component
   - New SaveDialog component with proper lifecycle management
   - Handles cleanup on unmount
   - Supports escape key and overlay click to close
   - No more dangling event listeners

3. Theme Detection Caching (Issue #2 partial)
   - Add 100ms cache to avoid repeated theme detection
   - Invalidate cache on actual theme changes
   - Reduces performance overhead

4. UI Scale Validation (Issue #7)
   - Add validation and constraints for uiScale prop
   - Clamp to range [0.5, 2.0]
   - Show warning in development when out of range

5. Error Handling Improvements (Issue #4)
   - Replace silent catches with console.warn in development
   - Better visibility of theme detection edge cases

6. Code Quality (Issue #8)
   - Extract CONTROL_BUTTON_STYLE constant to remove duplication
   - Cleaner button styling in CustomControls

7. TypeScript Strictness (Issue #10)
   - Replace (globalThis as any) with properly typed interface
   - Better type safety in theme detection

Changes:
- Add html-to-image production dependency
- Create SaveDialog component for export format selection
- Improve theme detection with caching and logging
- Add uiScale validation with warnings
- Better error handling throughout
- Code cleanup and type improvements

All tests passing (1410 passed | 13 skipped).
Builds successfully with no lint errors.
jhellerstein added a commit that referenced this pull request Oct 28, 2025
…#81)

* feat: Add semantic color tokens, dark mode support, and UI scaling

BREAKING CHANGE: Edge colors now use semantic tokens instead of hex values.
Legacy "color" field still supported for backward compatibility.

Features:
- Add semantic color token system for edges (default, muted, light, highlight-1/2/3, success, warning, danger)
- Implement theme-aware token mapping with automatic dark mode detection
- Add runtime edge color resolution based on current theme
- Increase dark mode edge contrast (brighter stroke colors for better visibility)
- Add dark mode safety override for legacy pure black colors
- Add UI scaling prop (uiScale) for IDE integrations (0.85 recommended)
- Add Save button to export visualization as PNG or JSON
- Add initialZoom prop to HydroscopeCore for custom initial zoom levels

Theme & Color Improvements:
- Enhanced detectDarkMode() with computed background luminance heuristic
- Added VS Code webview theme detection (.vscode-dark, .vscode-high-contrast)
- Brightened dark mode color palette for better contrast
- Updated dark default stroke colors (#cbd5e1, #e5e7eb)
- Added theme change listeners for dynamic updates
- Force light mode during tests for deterministic results

Visual Improvements:
- Add strokeWidth: 2 to all edge style mappings for consistency
- Update waviness to use "none"/"wavy" string values (backward compatible with boolean)
- Improve edge style validation with domain checking for all visual channels

Documentation:
- Add JSON_FORMAT.md documentation for color-token and theme-aware mappings
- Add UI_SCALING.md guide for IDE integrations
- Add migration script (scripts/update-color-tokens.mjs) for legacy JSONs
- Update examples with save functionality

Sample Data:
- Migrate paxos.json, paxos-flipped.json, paxos-old.json to use color-token
- Migrate simple_cluster.json to use color-token
- Add full backtrace data to simple_cluster nodes

CSS & Styling:
- Add comprehensive VS Code dark theme support in dark-mode.css
- Scale ReactFlow controls, minimap, and custom controls with uiScale
- Add pointer-events handling for scaled panel toggle buttons
- Improve dark mode specificity for all UI components

Architecture:
- StyleProcessor now uses getEdgeColorForToken(token, isDark) for runtime mapping
- Edge colors decoupled from node color palette changes
- Test-safe theme detection (no flakiness from environment differences)

Migration:
Legacy hex colors still work via fallback. To migrate:
  - Replace "color": "#2563eb" with "color-token": "highlight-1"
  - Replace "color": "#000000" with "color-token": "default"
  - Replace "color": "#6b7280" with "color-token": "muted"
  - Run: node scripts/update-color-tokens.mjs

Files Modified:
- src/components/Hydroscope.tsx
- src/components/HydroscopeCore.tsx
- src/shared/config/theme.ts
- src/shared/config/styling.ts
- src/utils/StyleProcessor.ts
- src/styles/dark-mode.css
- src/examples/hydroscope-example.tsx
- test-data/*.json (4 files)
- scripts/update-color-tokens.mjs (new)
- docs/UI_SCALING.md (new)

* fix: address PR review feedback for semantic color tokens

Addresses high-priority items from PR review:

1. PNG Export Implementation (Issue #1)
   - Replace fragile SVG serialization with html-to-image library
   - Add html-to-image@1.11.13 as production dependency
   - Properly handles CSS styles, fonts, and complex layouts
   - Uses 2x pixel ratio for better quality
   - Improved error handling with user-friendly messages

2. Memory Leak in Modal Creation (Issue #3)
   - Replace DOM manipulation with proper React component
   - New SaveDialog component with proper lifecycle management
   - Handles cleanup on unmount
   - Supports escape key and overlay click to close
   - No more dangling event listeners

3. Theme Detection Caching (Issue #2 partial)
   - Add 100ms cache to avoid repeated theme detection
   - Invalidate cache on actual theme changes
   - Reduces performance overhead

4. UI Scale Validation (Issue #7)
   - Add validation and constraints for uiScale prop
   - Clamp to range [0.5, 2.0]
   - Show warning in development when out of range

5. Error Handling Improvements (Issue #4)
   - Replace silent catches with console.warn in development
   - Better visibility of theme detection edge cases

6. Code Quality (Issue #8)
   - Extract CONTROL_BUTTON_STYLE constant to remove duplication
   - Cleaner button styling in CustomControls

7. TypeScript Strictness (Issue #10)
   - Replace (globalThis as any) with properly typed interface
   - Better type safety in theme detection

Changes:
- Add html-to-image production dependency
- Create SaveDialog component for export format selection
- Improve theme detection with caching and logging
- Add uiScale validation with warnings
- Better error handling throughout
- Code cleanup and type improvements

All tests passing (1410 passed | 13 skipped).
Builds successfully with no lint errors.

* refactor: address additional PR feedback

1. Luminance Calculation Optimization
   - Extract luminance calculation into cached helper function
   - Avoid redundant RGB parsing and floating-point operations
   - Cache background color string to skip recalculation

2. Download URL Cleanup Safety
   - Increase timeout from 100ms to 1000ms for both PNG and JSON
   - More reliable on slower systems and network conditions
   - Better ensures download completes before URL revocation

3. CSS Duplication Elimination
   - Refactor dark-mode.css to use CSS custom properties
   - Eliminate 677 lines of duplicated code (81% reduction)
   - Single source of truth for dark mode colors
   - Reduced from 834 lines to 157 lines
   - Much easier to maintain going forward

4. Type Guard Simplification
   - Remove redundant GlobalWithProcess interface
   - Use optional chaining directly on globalThis.process
   - Cleaner and more concise code

All checks passing:
- TypeScript compilation ✓
- Linting (prod + tests) ✓
- Build ✓
- Tests: 1410 passed | 13 skipped ✓

---------

Co-authored-by: Joe Hellerstein <jmhwork@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant