Add 6 missing 'domainId' for error tracing

[035966-L3]

Summary by CodeRabbit

• Chores
  • Enhanced error context tracking and reporting mechanisms across discussion, problem, and contest modules for improved system diagnostics and stability.

[coderabbitai]

Walkthrough

This pull request updates error constructor calls across three handler/model files to include domainId as the first parameter. Specifically, four DiscussionNotFoundError invocations in discussion.ts, one SolutionNotFoundError invocation in problem.ts, and one ContestNotFoundError invocation in contest.ts are modified to pass domainId alongside their existing resource identifiers. No control flow changes occur; only error instantiation signatures are affected.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify that the error constructor signatures for DiscussionNotFoundError, SolutionNotFoundError, and ContestNotFoundError have been updated to accept domainId as the first parameter
• Ensure all existing callers of these error constructors throughout the codebase remain consistent with the new signatures
• Confirm the domainId variable is properly accessible in all four error-throwing contexts within discussion.ts

Possibly related PRs

• core: 3+1 discussion module bug fixes #1079: Modifies discussion-related NotFoundError constructor calls to include domainId as the first argument, affecting the same error instantiation sites.

Suggested reviewers

• undefined-moe

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding domainId parameters to 6 error constructor calls across three files for improved error tracing.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7f7bff9 and 5e4119e.

📒 Files selected for processing (3)

• packages/hydrooj/src/handler/discussion.ts (1 hunks)
• packages/hydrooj/src/handler/problem.ts (1 hunks)
• packages/hydrooj/src/model/contest.ts (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (3)

packages/hydrooj/src/handler/discussion.ts (1)

packages/hydrooj/src/error.ts (1)

• DiscussionNotFoundError (81-81)

packages/hydrooj/src/handler/problem.ts (1)

packages/hydrooj/src/error.ts (1)

• SolutionNotFoundError (78-78)

packages/hydrooj/src/model/contest.ts (1)

packages/hydrooj/src/error.ts (1)

• ContestNotFoundError (80-80)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: build
• GitHub Check: Analyze (javascript)

🔇 Additional comments (3)

packages/hydrooj/src/model/contest.ts (1)

848-848: LGTM! Consistent error handling.

This change aligns with the existing pattern at line 830 where ContestNotFoundError is already constructed with domainId as the first parameter. The update improves error tracing by including domain context.

packages/hydrooj/src/handler/problem.ts (1)

915-915: LGTM! Consistent error handling.

This change aligns with the existing pattern at lines 845 and 903 where SolutionNotFoundError is already constructed with domainId as the first parameter.

packages/hydrooj/src/handler/discussion.ts (1)

360-363: LGTM! Consistent error handling.

These changes align with the existing pattern at lines 42, 47, and 50 where DiscussionNotFoundError is already constructed with domainId as the first parameter. All four error paths now consistently include domain context for better error tracing.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}