Skip to content

Commit

Permalink
Fix some typos (#259)
Browse files Browse the repository at this point in the history
  • Loading branch information
japinli authored Apr 30, 2024
1 parent d3601b1 commit 2c2630c
Show file tree
Hide file tree
Showing 12 changed files with 20 additions and 20 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ BEGIN
RETURN 0;
END IF;

-- Case senstivitiy
-- Case sensitivity

SELECT EXISTS (SELECT regexp_matches(tbl_name,'[A-Z]')) INTO is_case_sensitive;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ BEGIN
RETURN 0;
END IF;

-- Case senstivitiy
-- Case sensitivity

SELECT EXISTS (SELECT regexp_matches(tbl_name,'[A-Z]')) INTO is_case_sensitive;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ $$
RETURN result;
END;
$$ LANGUAGE PLPGSQL;
set columnar.qual_pushdown_correlation = 0.0;
set columnar.qual_pushdown_correlation_threshold = 0.0;
-- Create and load data
-- chunk_group_row_limit '1000', stripe_row_limit '2000'
set columnar.stripe_row_limit = 2000;
Expand All @@ -32,7 +32,7 @@ CREATE TABLE test_chunk_filtering (a int)
USING columnar;
INSERT INTO test_chunk_filtering SELECT generate_series(1,10000);
-- With vectorization and parallel execution enabled `filtered_row_count`
-- will not provided correct `Rows Removed by Filter`disable these features for now.
-- will not provided correct `Rows Removed by Filter` disable these features for now.
set columnar.enable_vectorization to false;
set columnar.enable_parallel_execution to false;
-- Verify that filtered_row_count is less than 1000 for the following queries
Expand Down Expand Up @@ -766,7 +766,7 @@ DETAIL: unparameterized; 0 clauses pushed down
(0 rows)

-- test that expressions on uncorrelated attributes are not pushed down
set columnar.qual_pushdown_correlation to default;
set columnar.qual_pushdown_correlation_threshold to default;
select * from coltest where x5 = 23484;
NOTICE: columnar planner: cannot push down clause: absolute correlation (0.006) of var attribute 5 is smaller than the value configured in "columnar.qual_pushdown_correlation_threshold" (0.900)
NOTICE: columnar planner: adding CustomScan path for coltest
Expand Down
2 changes: 1 addition & 1 deletion columnar/src/test/regress/expected/columnar_recursive.out
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ CREATE FUNCTION f(x INT) RETURNS INT AS $$
$$ LANGUAGE SQL;
--
-- Following query will start a write to t1 before finishing
-- write to t1, so it tests that we handle recursive writes
-- write to t2, so it tests that we handle recursive writes
-- correctly.
--
INSERT INTO t2 SELECT i, f(i) FROM generate_series(1, 5) i;
Expand Down
4 changes: 2 additions & 2 deletions columnar/src/test/regress/expected/columnar_tableoptions.out
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ WHERE regclass = 'table_options'::regclass;
table_options | 2000 | 150000 | 5 | pglz
(1 row)

-- test changing the chunk_group_row_limit
-- test changing the stripe_row_limit
SELECT columnar.alter_columnar_table_set('table_options', stripe_row_limit => 4000);
alter_columnar_table_set
--------------------------
Expand Down Expand Up @@ -273,7 +273,7 @@ HINT: chunk group row count limit must be between 1000 and 100000000
INSERT INTO table_options VALUES (1);
-- verify options are removed when table is dropped
DROP TABLE table_options;
-- we expect no entries in çstore.options for anything not found int pg_class
-- we expect no entries in columnar.options for anything not found in pg_class
SELECT * FROM columnar.options o WHERE o.regclass NOT IN (SELECT oid FROM pg_class);
regclass | chunk_group_row_limit | stripe_row_limit | compression_level | compression
----------+-----------------------+------------------+-------------------+-------------
Expand Down
2 changes: 1 addition & 1 deletion columnar/src/test/regress/expected/columnar_truncate.out
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ SELECT * from columnar_truncate_test;
---+---
(0 rows)

-- make sure TRUNATE deletes metadata for old relfilenode
-- make sure TRUNCATE deletes metadata for old relfilenode
SELECT :columnar_data_files_before_truncate - count(distinct storage_id) FROM columnar.stripe;
?column?
----------
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
-- Testing data types without comparison operators
--
-- If a data type doesn't have comparison operators:
-- (1) we should check if type familiy has defined one
-- (1) we should check if type family has defined one
-- (2) or we should store NULL for min/max values
--
-- Verify that (1) min/max entries in columnar.chunk is NULL as expected
-- (2) min/max for types that have familiy comparison operator is use and values are set
-- (2) min/max for types that have family comparison operator is use and values are set
-- (3) we can run queries which has equality conditions in WHERE clause for that column with correct results
--
-- varchar
Expand Down
6 changes: 3 additions & 3 deletions columnar/src/test/regress/sql/columnar_chunk_filtering.sql
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ $$
END;
$$ LANGUAGE PLPGSQL;

set columnar.qual_pushdown_correlation = 0.0;
set columnar.qual_pushdown_correlation_threshold = 0.0;

-- Create and load data
-- chunk_group_row_limit '1000', stripe_row_limit '2000'
Expand All @@ -38,7 +38,7 @@ CREATE TABLE test_chunk_filtering (a int)
INSERT INTO test_chunk_filtering SELECT generate_series(1,10000);

-- With vectorization and parallel execution enabled `filtered_row_count`
-- will not provided correct `Rows Removed by Filter`disable these features for now.
-- will not provided correct `Rows Removed by Filter` disable these features for now.

set columnar.enable_vectorization to false;
set columnar.enable_parallel_execution to false;
Expand Down Expand Up @@ -289,7 +289,7 @@ analyze coltest;
select * from coltest where coltest = (1,1,1,1);

-- test that expressions on uncorrelated attributes are not pushed down
set columnar.qual_pushdown_correlation to default;
set columnar.qual_pushdown_correlation_threshold to default;
select * from coltest where x5 = 23484;

-- test that expressions on volatile functions are not pushed down
Expand Down
2 changes: 1 addition & 1 deletion columnar/src/test/regress/sql/columnar_recursive.sql
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ $$ LANGUAGE SQL;

--
-- Following query will start a write to t1 before finishing
-- write to t1, so it tests that we handle recursive writes
-- write to t2, so it tests that we handle recursive writes
-- correctly.
--
INSERT INTO t2 SELECT i, f(i) FROM generate_series(1, 5) i;
Expand Down
4 changes: 2 additions & 2 deletions columnar/src/test/regress/sql/columnar_tableoptions.sql
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ SELECT columnar.alter_columnar_table_set('table_options', chunk_group_row_limit
SELECT * FROM columnar.options
WHERE regclass = 'table_options'::regclass;

-- test changing the chunk_group_row_limit
-- test changing the stripe_row_limit
SELECT columnar.alter_columnar_table_set('table_options', stripe_row_limit => 4000);

-- show table_options settings
Expand Down Expand Up @@ -152,7 +152,7 @@ INSERT INTO table_options VALUES (1);

-- verify options are removed when table is dropped
DROP TABLE table_options;
-- we expect no entries in çstore.options for anything not found int pg_class
-- we expect no entries in columnar.options for anything not found in pg_class
SELECT * FROM columnar.options o WHERE o.regclass NOT IN (SELECT oid FROM pg_class);

SET client_min_messages TO warning;
Expand Down
2 changes: 1 addition & 1 deletion columnar/src/test/regress/sql/columnar_truncate.sql
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ SELECT * from columnar_truncate_test_regular;
TRUNCATE TABLE columnar_truncate_test;
SELECT * from columnar_truncate_test;

-- make sure TRUNATE deletes metadata for old relfilenode
-- make sure TRUNCATE deletes metadata for old relfilenode
SELECT :columnar_data_files_before_truncate - count(distinct storage_id) FROM columnar.stripe;

-- test if truncation in the same transaction that created the table works properly
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
-- Testing data types without comparison operators
--
-- If a data type doesn't have comparison operators:
-- (1) we should check if type familiy has defined one
-- (1) we should check if type family has defined one
-- (2) or we should store NULL for min/max values
--
-- Verify that (1) min/max entries in columnar.chunk is NULL as expected
-- (2) min/max for types that have familiy comparison operator is use and values are set
-- (2) min/max for types that have family comparison operator is use and values are set
-- (3) we can run queries which has equality conditions in WHERE clause for that column with correct results
--

Expand Down

0 comments on commit 2c2630c

Please sign in to comment.