Chinese support

[echo-LuGuang]

I discovered this great project in Laravel News today, but after using it, I found that it is not friendly to Chinese support.

// CreatesNewMarkdownPostFile.php

public function __construct(string $title, ?string $description, ?string $category, ?string $author, ?string $date = null, ?string $customContent = null)
    {
        $this->title = $title;
        $this->description = $description ?? 'A short description used in previews and SEO';
        $this->category = $category ?? 'blog';
        $this->author = $author ?? 'default';
        $this->customContent = $customContent;

        $this->date = Carbon::make($date ?? Carbon::now())->format('Y-m-d H:i');
        $this->identifier = Str::slug($title);   // <--  here
    }

dump(Str::slug('你好世界', language: 'zh-CN')); // ✅
dump(Str::slug('你好世界')); // ❌

### Tasks

[emmadesilva]

Hi! Thank you so much for using Hyde! This is definitely something we need to support, and some of the new features in v2 support internationalisation by default. But since v1 is LTS I’m going to make sure we support this. If you have time, open source contributions are highly appreciated (check out the hydephp/develop repo) otherwise I’ll make a PR when I can, and possibly ping you to get your help to try it out? Thanks again for using Hyde!

…

On Wed, 11 Dec 2024 at 07:12, WHOAMI ***@***.***> wrote: I discovered this great project in Laravel News today, but after using it, I found that it is not friendly to Chinese support. image.png (view on web) <https://github.com/user-attachments/assets/07cda1c8-f92a-4e48-8c31-809182281b74> image.png (view on web) <https://github.com/user-attachments/assets/94a72f4b-7b52-4478-aedd-42d549e3f4e7> // CreatesNewMarkdownPostFile.php public function __construct(string $title, ?string $description, ?string $category, ?string $author, ?string $date = null, ?string $customContent = null) { $this->title = $title; $this->description = $description ?? 'A short description used in previews and SEO'; $this->category = $category ?? 'blog'; $this->author = $author ?? 'default'; $this->customContent = $customContent; $this->date = Carbon::make($date ?? Carbon::now())->format('Y-m-d H:i'); $this->identifier = Str::slug($title); // <-- here } dump(Str::slug('你好世界', language: 'zh-CN')); // ✅dump(Str::slug('你好世界')); // ❌ — Reply to this email directly, view it on GitHub <#269>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AWV4WAOAXZOGOUGNRUPUA2L2E7JTRAVCNFSM6AAAAABTMWXSYCVHI2DSMVQWIX3LMV43ASLTON2WKOZSG4ZTCOJSGI4TONI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[emmadesilva]

@echo-LuGuang Two follow up questions:

1. What is your expected behaviour here? We really don't want the filename to be empty of course, but should it be transliterated to ASCII, or should we use the Chinese character directly? I'm not sure what the URL support is for that.

2. I see that specifying the language in the Str::slug call returns ni-hao-shi-jie, so if we go with the transliteration route, I'm thinking about the best implementation route. I think we could either always transliterate input before making slugs, or we use the app language as the language parameter, but that would require configuration on your part. Do you have a preference here?

[echo-LuGuang]

1. Yes, I would like to transliterate it into ASCII, Instead of the original Chinese string.
2. I think using application languages as language parameters is great.

Thank you. ❤️

[emmadesilva]

Hey @echo-LuGuang! Just wanted to let you know that this has been fixed in https://github.com/hydephp/framework/releases/tag/v1.7.5.

Thank you so much for the clear reproduction steps and implementation ideas - it really made it so much easier to fix this issue. Please let me know if the fix works for you, and if you find anything else we can improve. 🎩