Refactor the backend structure of the static page builder command process #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply fixes from StyleCI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This v0.10.x PR is centered around the static page builder command and its related methods.
While the user experience should not notably differ, this update massively restructures and improves the internal API by reducing repeating boilerplate code into dynamic method callers, extracted traits for shared logic, and separating the BuildService class to include several new helper methods. All to improve maintainability.
The accompanying hyde/hyde PR also improves the overall test coverage both by reducing complexity and boilerplate, but also by adding a few new tests.