Internal: Update test workflow to dynamically install the proper framework version #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caendesilva
added a commit
to hydephp/develop
that referenced
this pull request
Mar 20, 2023
Fixes unrelated test failures in hydephp/framework#572. We mostly have this check to catch any mistakes before merging config changes when developing in the monorepo.
caendesilva
added a commit
to hydephp/develop
that referenced
this pull request
Mar 20, 2023
Fixes unrelated test failures in hydephp/framework#572. We mostly have this check to catch any mistakes before merging config changes when developing in the monorepo.
…-in-monorepo Skip unit test when not running in the monorepo hydephp/develop@48955e5
caendesilva
force-pushed
the
update-test-workflow-to-install-the-proper-branch-dependencies
branch
from
a70f353 to
63174f4
Compare
caendesilva
deleted the
update-test-workflow-to-install-the-proper-branch-dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue in #571 which fails due to the workflow checking out the develop branch.
Also cherry picks hydephp/develop#1339: Skip unit test when not running in the monorepo hydephp/develop@48955e5