Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add back Codecov with all files #558

Merged
merged 6 commits into from
Aug 18, 2022

Conversation

thomasrockhu-codecov
Copy link
Contributor

@thomasrockhu-codecov thomasrockhu-codecov commented Aug 17, 2022

@caendesilva sorry for taking so long, I have an idea on how to get 94ef842 working. I don't actually know how to run the GitHub Actions in this PR, but if possible, I'd like to see if this clears up the issue from https://community.codecov.com/t/codecov-not-discovering-files-when-uploaded-in-ci/3691/2

@caendesilva
Copy link
Member

Hi there @thomasrockhu-codecov! I actually managed to get Codecov to work in the new monorepo https://github.com/hydephp/develop/. I actually have no idea why it works there though. I'll see if I can enable your run so we can try to debug this.

@caendesilva
Copy link
Member

I'm not seeing anything in the recent commits section. https://app.codecov.io/gh/hydephp/framework

@thomasrockhu-codecov
Copy link
Contributor Author

@caendesilva probably would help if we were actually collecting coverage 😬. Pushed a new commit, hopefully this one works.

@caendesilva
Copy link
Member

caendesilva commented Aug 17, 2022

@caendesilva probably would help if we were actually collecting coverage 😬. Pushed a new commit, hopefully this one works.

Whoops! I'm having a ton of issues with GitHub at the moment, which I think it's why some runs failed, but I can't access the logs. I see that we need to re-add a code coverage driver. I'll see if GitHub lets me add it.

Edit: yeah some tests failed due to GitHub being down so the repo couldn't be cloned. One is complaining that we don't have a code coverage driver. I left a review where I think it needs to go.

@thomasrockhu-codecov
Copy link
Contributor Author

@caendesilva yeah, looks like we are having troubles with GitHub too. I pushed the change and some log statements

@caendesilva
Copy link
Member

@caendesilva yeah, looks like we are having troubles with GitHub too. I pushed the change and some log statements

Alright cool! I approved the workflow. Hoping it works this time!

@thomasrockhu-codecov
Copy link
Contributor Author

@caendesilva yikes, moved the logs after the Codecov step

@caendesilva
Copy link
Member

Yeah I'm a bit stumped as to what's happening. If it helps, we don't need to put the reports in a subdirectory as we are not pushing any commits to the repository.

@thomasrockhu-codecov
Copy link
Contributor Author

@caendesilva ok what if we remove the directory-specific search and try all the arguments

@caendesilva
Copy link
Member

@caendesilva ok what if we remove the directory-specific search and try all the arguments

Let's try it!

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #558 (2e97759) into master (1694d9f) will decrease coverage by 9.09%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##            master     #558      +/-   ##
===========================================
- Coverage   100.00%   90.90%   -9.10%     
===========================================
  Files            1        3       +2     
  Lines           10       33      +23     
===========================================
+ Hits            10       30      +20     
- Misses           0        3       +3     
Impacted Files Coverage Δ
a/framework/framework/hyde/app/bootstrap.php 90.90% <0.00%> (ø)
...er/work/framework/framework/hyde/app/bootstrap.php 90.90% <0.00%> (ø)
app/bootstrap.php 90.90% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva
Copy link
Member

Codecov Report

Merging #558 (e49ca31) into master (1694d9f) will decrease coverage by 9.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##            master     #558      +/-   ##
===========================================
- Coverage   100.00%   90.90%   -9.10%     
===========================================
  Files            1        1              
  Lines           10       11       +1     
===========================================
  Hits            10       10              
- Misses           0        1       +1     

Impacted Files Coverage Δ
hyde/app/bootstrap.php 90.90% <0.00%> (ø)
Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e15613...e49ca31. Read the comment docs.

Oh yeah, awesome!

@thomasrockhu-codecov
Copy link
Contributor Author

@caendesilva woo, ok we're uploading. I'm trying some path fixes here that might help get all of the coverage

@caendesilva
Copy link
Member

@caendesilva woo, ok we're uploading. I'm trying some path fixes here that might help get all of the coverage

Woo awesome!

@thomasrockhu-codecov
Copy link
Contributor Author

@caendesilva, ok, for the coverage reports being uploaded, I'm really only seeing this app/bootstrap.php file. This looks true in CI/CD too (see this run). Are we missing a step to collect coverage for all files?

@caendesilva
Copy link
Member

@caendesilva, ok, for the coverage reports being uploaded, I'm really only seeing this app/bootstrap.php file. This looks true in CI/CD too (see this run). Are we missing a step to collect coverage for all files?

It's possible the runner needs to be reconfigured. It's pretty late here, but I'll take a look at it tomorrow. Thank you so so much for your help so far @thomasrockhu-codecov!

@caendesilva
Copy link
Member

Since everything seems to be working, I'll go ahead and merge this PR and fix the path in a separate PR. Once again, thank you so much!

By the way, I lost access to the Codecov account I originally used when I converted @hydephp to an organization. So I won't be able to mark it as resolved, but from my end it all looks great, so you can mark it as resolved if you want. Thanks a bunch!

@caendesilva caendesilva merged commit 6643161 into hydephp:master Aug 18, 2022
@thomasrockhu-codecov
Copy link
Contributor Author

@caendesilva sounds good! Let me know if you run into any issues that I can help with.

@thomasrockhu-codecov thomasrockhu-codecov deleted the codecov branch August 19, 2022 00:06
caendesilva pushed a commit that referenced this pull request Oct 8, 2022
…mespace

Fix: move NavigationDataTest from 'Model' to 'Feature' hydephp/develop@f1113ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants