Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create image link helper, fix #434 #522

Merged
merged 3 commits into from
Jun 6, 2022
Merged

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jun 6, 2022

Adds a new helper, accessible in two ways:

$image->getLink($currentPage)
And Hyde::image('foo.png', 'blog/post')

In both cases, a relative link with the appropriate level of ../ will be returned.

@caendesilva caendesilva linked an issue Jun 6, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #522 (9201367) into master (90b338a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #522   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           11        11           
=========================================
  Hits            11        11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90b338a...9201367. Read the comment docs.

@caendesilva caendesilva merged commit 74439f0 into master Jun 6, 2022
@caendesilva caendesilva deleted the create-image-file-object branch June 6, 2022 17:40
caendesilva pushed a commit that referenced this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add image locator helper to make local image paths more forgiving
1 participant