Improve RSS image handling and feed and sitemap generation processes #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes some debug output and preflight checks. We don't need a notice stating that remote images will increase the time, since now by default we log the HTTP requests making it obvious why it's taking longer.
Apply fixes from StyleCI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the RSS feed by allowing remote images in enclosures. When an image stored externally is detected, Hyde will make an HTTP HEAD request to try to get the content length from the response headers. If this fails, or if a local image is not found, a notice is sent to the console and the length is set to zero.
It also adds two new commands for compiling the sitemap and RSS feed respectively: