Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration and autodiscovery improvements #340

Merged
merged 80 commits into from
May 15, 2022
Merged
Changes from 1 commit
Commits
Show all changes
80 commits
Select commit Hold shift + click to select a range
9fc7e47
Deprecate version bindings
caendesilva May 14, 2022
da1c46d
Bind the project path in the service container
caendesilva May 14, 2022
67848cf
Add "hidden" config option to disable creation of default directories
caendesilva May 14, 2022
13dde31
Apply fixes from StyleCI
StyleCIBot May 14, 2022
28fe5da
Merge pull request #339 from hydephp/analysis-KZEdZ3
caendesilva May 14, 2022
9b6d0d4
Allow source directories to be changed
caendesilva May 14, 2022
bfbfc38
Merge branch 'configuration-improvements' of github.com:hydephp/frame…
caendesilva May 14, 2022
28963e0
Switch to handling the base path as a static class property
caendesilva May 15, 2022
ed7430c
Replace config customization with static properties (experiment)
caendesilva May 15, 2022
25d3615
Revert to original behaviour
caendesilva May 15, 2022
bbffc74
Register the source directories at runtime in the service provider
caendesilva May 15, 2022
a1c9b4c
Apply fixes from StyleCI
StyleCIBot May 15, 2022
b6a77ef
Merge pull request #341 from hydephp/analysis-OMWoRW
caendesilva May 15, 2022
8a7bb5d
Add todos
caendesilva May 15, 2022
7f0bddc
Create test for source directory changing
caendesilva May 15, 2022
ab37a4f
Add @package HydeAutoDiscovery annotations
caendesilva May 15, 2022
b4333cc
Use the model's source direcory property for autodiscovery
caendesilva May 15, 2022
ea690fe
Deprecated, considering rename to DiscoveryService
caendesilva May 15, 2022
eeaffe5
Deprecate CreatesDefaultDirectories
caendesilva May 15, 2022
7636d95
Add @todo Create the required directories if they don't exist.
caendesilva May 15, 2022
9e515a6
Add implementation idea to todo
caendesilva May 15, 2022
ff9b112
Automatically add custom Blade views to view discovery
caendesilva May 15, 2022
9d9cbff
Utalize the $sourceDirectory property in build services
caendesilva May 15, 2022
c08f766
Fix #343
caendesilva May 15, 2022
ae9cb88
Apply fixes from StyleCI
StyleCIBot May 15, 2022
1822fcb
Merge pull request #344 from hydephp/analysis-4xdeMP
caendesilva May 15, 2022
41bd056
Restructure the tests
caendesilva May 15, 2022
cec4dba
Create the test
caendesilva May 15, 2022
c17246e
Apply fixes from StyleCI
StyleCIBot May 15, 2022
93ea248
Merge pull request #345 from hydephp/analysis-WNQA5j
caendesilva May 15, 2022
0c2f040
Rename BuildService to DiscoveryService
caendesilva May 15, 2022
3b046bd
Update PHPDoc comment
caendesilva May 15, 2022
b4ecfc3
Use the DiscoveryService instead of BuildService
caendesilva May 15, 2022
17c584d
Rename BuildServiceTest to DiscoveryServiceTest
caendesilva May 15, 2022
1995bc5
Rename the DiscoveryService unit test
caendesilva May 15, 2022
af5ab4c
Update the test annotation to match new name
caendesilva May 15, 2022
0578dc7
Apply fixes from StyleCI
StyleCIBot May 15, 2022
3b545bb
Merge pull request #346 from hydephp/analysis-QMbwNw
caendesilva May 15, 2022
75a5c99
Merge pull request #347 from hydephp/change-buildservice-to-discovery…
caendesilva May 15, 2022
5854701
Add sidebar config offset, fix #307
caendesilva May 15, 2022
d040952
Merge pull request #348 from hydephp/add-sidebar-priority-offset-for-…
caendesilva May 15, 2022
8f8170e
Replace deprecated method
caendesilva May 15, 2022
5b0c7f7
Remove deprecated relativePath() helper
caendesilva May 15, 2022
a17d449
Add documentation to distinguish paths/links
caendesilva May 15, 2022
c824699
Fix #330, Create helper to make pretty URLs if enabled
caendesilva May 15, 2022
7699230
Shorten the test filename
caendesilva May 15, 2022
e114013
Clarify relativeLink helper parameters
caendesilva May 15, 2022
335e6dd
Add unit test for the relativeLink helper
caendesilva May 15, 2022
46a9da6
Add support for pretty relative links
caendesilva May 15, 2022
5fe8586
Use the Hyde::pageLink() helper in Blade views
caendesilva May 15, 2022
65be4a5
Use the Hyde::pageLink() helper for docsIndexPath
caendesilva May 15, 2022
db1d615
Use the relative link helper to get pretty links
caendesilva May 15, 2022
cd57985
Add @todo #350
caendesilva May 15, 2022
dfaf3fe
Apply fixes from StyleCI
StyleCIBot May 15, 2022
23b33f1
Merge pull request #352 from hydephp/analysis-Vr1wkV
caendesilva May 15, 2022
ee2841d
Change assertion naming to match related test
caendesilva May 15, 2022
740bcf1
Rewrite `index.html` to `/`, fixing half of #353
caendesilva May 15, 2022
3f76ec2
Merge branch '330-add-option-for-pretty-urls' of github.com:hydephp/f…
caendesilva May 15, 2022
f66f9a2
Apply fixes from StyleCI
StyleCIBot May 15, 2022
89c3c64
Merge pull request #355 from hydephp/analysis-D2aJvn
caendesilva May 15, 2022
4e7badd
Add tests for inverse index rewrite case
caendesilva May 15, 2022
43aaf1c
Merge branch '330-add-option-for-pretty-urls' of github.com:hydephp/f…
caendesilva May 15, 2022
c65434d
Apply fixes from StyleCI
StyleCIBot May 15, 2022
3f01ef7
Merge pull request #356 from hydephp/analysis-KZEdQe
caendesilva May 15, 2022
550edf7
Rewrite index docs path to pretty url, fix #353
caendesilva May 15, 2022
7db6a59
Add option for pretty urls fix #330
caendesilva May 15, 2022
972bd8b
Apply fixes from StyleCI
StyleCIBot May 15, 2022
b1f8216
Merge pull request #357 from hydephp/analysis-0gN9lm
caendesilva May 15, 2022
cd3183c
Merge pull request #354 from hydephp/330-add-option-for-pretty-urls
caendesilva May 15, 2022
1c31c71
Reset (currently unused) @HydeConfigVersion annotation
caendesilva May 15, 2022
566329d
Add the config option for Pretty URLs
caendesilva May 15, 2022
927fe66
Fix #350, Use the model path properties
caendesilva May 15, 2022
10e145e
Add helpers to make it easier to refactor source paths
caendesilva May 15, 2022
d286f0b
Refactor to use new dynamic path helpers
caendesilva May 15, 2022
79da19b
Refactor to use getDocumentationPagePath()
caendesilva May 15, 2022
e915ccb
Refactor to use getMarkdownPagePath()
caendesilva May 15, 2022
93fdaed
Refactor to use getMarkdownPostPath()
caendesilva May 15, 2022
b57b371
Refactor to use getDocumentationPagePath()
caendesilva May 15, 2022
f649449
Apply fixes from StyleCI
StyleCIBot May 15, 2022
e237f1c
Merge pull request #358 from hydephp/analysis-lK6aPQ
caendesilva May 15, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove deprecated relativePath() helper
  • Loading branch information
caendesilva committed May 15, 2022
commit 5b0c7f726ae0810822e758c4c647dfd4a7b46a72
8 changes: 0 additions & 8 deletions src/Concerns/Internal/FileHelpers.php
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,6 @@ public static function vendorPath(string $path = ''): string
return static::path('vendor/hyde/framework/'.trim($path, '/\\'));
}

/**
* @deprecated use relativeLink() instead
*/
public static function relativePath(string $destination, string $current = ''): string
{
return static::relativeLink($destination, $current);
}

/**
* Inject the proper number of `../` before the links in Blade templates.
*
Expand Down