Merge pull request #564 from hydephp/develop

HydePHP v1.0.0 - Release Candidate Three
hydephp · Mar 11, 2023 · ed118d4 · ed118d4
2 parents b492ebc + 05cceb1
commit ed118d4
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/src/Foundation/HydeKernel.php b/src/Foundation/HydeKernel.php
@@ -49,7 +49,7 @@ class HydeKernel implements SerializableContract
     use Serializable;
     use Macroable;
 
-    final public const VERSION = '1.0.0-RC.2';
+    final public const VERSION = '1.0.0-RC.3';
 
     protected static self $instance;
 

diff --git a/src/Markdown/Contracts/FrontMatter/PageSchema.php b/src/Markdown/Contracts/FrontMatter/PageSchema.php
@@ -13,7 +13,7 @@ interface PageSchema extends FrontMatterSchema
 {
     public const PAGE_SCHEMA = [
         'title'         => 'string',
-        'canonicalUrl'  => 'string',
+        'canonicalUrl'  => 'string', // DEPRECATED
         'navigation'    => NavigationSchema::NAVIGATION_SCHEMA,
     ];
 }
diff --git a/src/Pages/Concerns/HydePage.php b/src/Pages/Concerns/HydePage.php
@@ -66,7 +66,9 @@ abstract class HydePage implements PageSchema, SerializableContract
     public PageMetadataBag $metadata;
     public NavigationData $navigation;
 
-    public string $title;
+    public readonly string $title;
+
+    /** @deprecated v1.0.0-RC.3 - This property requires information that is setup-dependent, and will work better through a runtime accessor. Since it is mainly related to blog posts, it will be moved there. */
     public ?string $canonicalUrl;
 
     public static function make(string $identifier = '', FrontMatter|array $matter = []): static

diff --git a/tests/Feature/HydePageTest.php b/tests/Feature/HydePageTest.php
@@ -370,9 +370,7 @@ public function test_all_returns_collection_of_all_parsed_source_files_from_page
             MarkdownPage::all()
         );
         $this->assertEquals(
-            ['_pages/foo.md' => tap(new MarkdownPage('foo'), function ($page) {
-                $page->title = 'Foo';
-            })],
+            ['_pages/foo.md' => (new MarkdownPage('foo'))],
             MarkdownPage::all()->all()
         );
         Filesystem::unlink('_pages/foo.md');