Merge pull request #412 from hydephp/410-search-index-generator-break…

…s-when-storing-documentation-page-source-files-in-subdirectories Fix #410: Search index generator breaks when storing documentation page source files in subdirectories hydephp/develop@0ea94ec
hydephp · Aug 11, 2022 · cd697fa · cd697fa
1 parent 7ac96b4
commit cd697fa
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/Actions/GeneratesDocumentationSearchIndexFile.php b/src/Actions/GeneratesDocumentationSearchIndexFile.php
@@ -62,10 +62,10 @@ public function generate(): static
     public function generatePageObject(DocumentationPage $page): object
     {
         return (object) [
-            'slug' => $page->identifier,
+            'slug' => basename($page->identifier),
             'title' => $page->title,
             'content' => trim($this->getSearchContentForDocument($page)),
-            'destination' => $this->getDestinationForSlug($page->identifier),
+            'destination' => $this->getDestinationForSlug(basename($page->identifier)),
         ];
     }
 

diff --git a/tests/Feature/Actions/GeneratesDocumentationSearchIndexFileTest.php b/tests/Feature/Actions/GeneratesDocumentationSearchIndexFileTest.php
@@ -138,4 +138,15 @@ public function test_excluded_pages_are_not_present_in_the_search_index()
 
         unlink(Hyde::path('_docs/excluded.md'));
     }
+
+    public function test_nested_source_files_do_not_retain_directory_name_in_search_index()
+    {
+        mkdir(Hyde::path('_docs/foo'));
+        touch(Hyde::path('_docs/foo/bar.md'));
+
+        $this->assertStringNotContainsString('foo', (new Action())->generate()->getJson());
+
+        unlink(Hyde::path('_docs/foo/bar.md'));
+        rmdir(Hyde::path('_docs/foo'));
+    }
 }