[2.x] Normalize @ and & in makeSlug helper #2314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the makeSlug helper to replace '@' with 'at' and '&' with 'and' before slugging. Adjusted related unit tests to reflect the new normalization behavior.
emmadesilva
force-pushed
the
resolve-final-todos
branch
from
11eed23 to
db2dbc6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2314 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 2000 2000
===========================================
Files 197 197
Lines 5174 5178 +4
===========================================
+ Hits 5174 5178 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emmadesilva
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the makeSlug helper to replace '@' with 'at' and '&' with 'and' before slugging. Adjusted related unit tests to reflect the new normalization behavior.