Skip to content

Conversation

@emmadesilva
Copy link
Member

Also considered has, but exists is generally better for clarity, as it directly indicates that you're checking for the presence of a file. has can be more ambiguous, as it might imply ownership or possession rather than existence. Therefore, exists is often preferred for methods that check for the presence of an item. It's also what the Laravel Filesystem facade uses.

Part of #1904

@emmadesilva emmadesilva marked this pull request as ready for review September 8, 2024 09:18
Also considered `has`, but exists is generally better for clarity, as it directly indicates that you're checking for the presence of a file. has can be more ambiguous, as it might imply ownership or possession rather than existence. Therefore, exists is often preferred for methods that check for the presence of an item. It's also what the Laravel Filesystem facade uses
@emmadesilva emmadesilva force-pushed the rename-asset-has-media-file-to-asset-exists branch from 0d313a8 to a897d0d Compare September 8, 2024 09:21
@codecov
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8dfb5ce) to head (a897d0d).
Report is 2 commits behind head on normalize-the-asset-api.

Additional details and impacted files
@@                     Coverage Diff                     @@
##             normalize-the-asset-api     #1957   +/-   ##
===========================================================
  Coverage                     100.00%   100.00%           
  Complexity                      1883      1883           
===========================================================
  Files                            193       193           
  Lines                           4977      4977           
===========================================================
  Hits                            4977      4977           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmadesilva emmadesilva merged commit 37a791d into normalize-the-asset-api Sep 8, 2024
@emmadesilva emmadesilva deleted the rename-asset-has-media-file-to-asset-exists branch September 8, 2024 09:23
@emmadesilva emmadesilva mentioned this pull request Oct 4, 2024
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants