[2.x] Normalize asset cache busting #1915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmadesilva
force-pushed
the
normalize-asset-cache-busting
branch
from
d11bdd5 to
d47b220
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## normalize-the-asset-api #1915 +/- ##
===========================================================
Coverage 100.00% 100.00%
- Complexity 1871 1873 +2
===========================================================
Files 192 192
Lines 4942 4944 +2
===========================================================
+ Hits 4942 4944 +2 ☔ View full report in Codecov by Sentry. |
Makes the refactor easier as I can click to get to the code location
emmadesilva
force-pushed
the
normalize-asset-cache-busting
branch
from
977cb81 to
244a22e
Compare
emmadesilva
force-pushed
the
normalize-asset-cache-busting
branch
from
56bf797 to
227b883
Compare
emmadesilva
force-pushed
the
normalize-asset-cache-busting
branch
from
1790651 to
41416b4
Compare
emmadesilva
force-pushed
the
normalize-asset-cache-busting
branch
from
5b30aa7 to
3b57fe8
Compare
emmadesilva
force-pushed
the
normalize-asset-cache-busting
branch
from
94112c0 to
d8cb4e4
Compare
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #1904 and fixes a major discrepancy where
Asset::mediaLink()adds a cache busting key butHyde::mediaLink()does not. Now, all asset helpers will use cache busting when enabled.