-
-
Notifications
You must be signed in to change notification settings - Fork 12
Refactor realtime compiler to handle virtual routes through the service container #1858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1858 +/- ##
=========================================
Coverage 99.93% 99.93%
Complexity 1764 1764
=========================================
Files 182 182
Lines 4704 4704
=========================================
Hits 4701 4701
Misses 3 3 ☔ View full report in Codecov by Sentry. |
5b841b8 to
508625e
Compare
d584648 to
31b0462
Compare
Member
Author
|
We can actually change this to target the master branch as it's more compatible than I expected. |
This reverts commit 3b45431.
This reverts commit 6d50cbc.
This refactoring allows for more flexibility, as the response can now be generated dynamically when the route is accessed, rather than being created at registration time.
58d902b to
097bcfb
Compare
Member
Author
|
Rebased to target master branch |
It's possible the usage desires an overwrite. It should be up to the registration logic to determine if a page should be added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a new system to instead of hardcoding virtual routes, we store them in the service container (which is loaded when the router boots)
This means it's also possible for package developers to add realtime compiler routes: