Skip to content

Conversation

@emmadesilva
Copy link
Member

@emmadesilva emmadesilva commented Jul 15, 2024

Consider this setup:

_docs/index.md
_pages/about/index.md
_pages/about/contact.md

Which will generate the following structure:

_site/docs/index.html
_site/about/index.html
_site/about/contact.html

A web server will route this as expected:

/docs/ -> _site/docs/index.html
/about/ -> _site/about/index.html
/about/contact/ -> _site/about/contact.html

# And of course:

/docs -> _site/docs/index.html
/about -> _site/about/index.html
/docs/index -> _site/docs/index.html
/about/index -> _site/about/index.html

So this PR makes so that the realtime compiler can serve any arbitrary nested index page.

@emmadesilva emmadesilva force-pushed the improve-realtime-compiler-routing-for-nested-index-pages branch from cb264dc to d4cb5ce Compare July 15, 2024 08:00
@codecov
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f7c6e21) to head (d1b9ec5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master     #1852   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      1764      1764           
===========================================
  Files            182       182           
  Lines           4712      4712           
===========================================
  Hits            4712      4712           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmadesilva emmadesilva marked this pull request as ready for review July 15, 2024 15:49
@emmadesilva emmadesilva merged commit 378b2d9 into master Jul 15, 2024
@emmadesilva emmadesilva deleted the improve-realtime-compiler-routing-for-nested-index-pages branch July 15, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants