Skip to content

Conversation

@emmadesilva
Copy link
Member

Having this on another branch does not work anymore when new major versions have BC breaks, so we need to version control these alongside the code.

@github-actions github-actions bot added the internal This pull request does not affect package code label Jul 9, 2024
@codecov
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4d509a8) to head (be472f9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master     #1814   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      1764      1764           
===========================================
  Files            182       182           
  Lines           4712      4712           
===========================================
  Hits            4712      4712           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmadesilva emmadesilva force-pushed the version-control-gh-pages-configuration branch 2 times, most recently from 56f02f5 to 65ea399 Compare July 9, 2024 09:05
@emmadesilva emmadesilva force-pushed the version-control-gh-pages-configuration branch from b3345ab to 17f0043 Compare July 9, 2024 09:48
From: Caen De Silva
Date: Wed Jun 8 19:06:56 2022 +0200
Subject: Create .gitignore

Original commit: 5aa7146
@emmadesilva emmadesilva temporarily deployed to pr-documentation-1814 July 9, 2024 10:31 — with GitHub Actions Inactive
@emmadesilva emmadesilva force-pushed the version-control-gh-pages-configuration branch from d8edcf0 to 4095a06 Compare July 9, 2024 10:37
@emmadesilva emmadesilva temporarily deployed to pr-documentation-1814 July 9, 2024 10:37 — with GitHub Actions Inactive
@emmadesilva emmadesilva temporarily deployed to pr-documentation-1814 July 9, 2024 10:38 — with GitHub Actions Inactive
@emmadesilva emmadesilva force-pushed the version-control-gh-pages-configuration branch from 3a74fb3 to 15f85ce Compare July 9, 2024 10:40
@emmadesilva emmadesilva temporarily deployed to pr-documentation-1814 July 9, 2024 10:40 — with GitHub Actions Inactive
@emmadesilva emmadesilva temporarily deployed to pr-documentation-1814 July 9, 2024 10:44 — with GitHub Actions Inactive
@emmadesilva emmadesilva temporarily deployed to pr-documentation-1814 July 9, 2024 10:45 — with GitHub Actions Inactive
@emmadesilva
Copy link
Member Author

We may also want to consider adding the fixtures not in this repository to version control, and to matrix test them.

@emmadesilva emmadesilva marked this pull request as ready for review July 9, 2024 10:48
@emmadesilva emmadesilva merged commit 331eb9c into master Jul 9, 2024
@emmadesilva emmadesilva deleted the version-control-gh-pages-configuration branch July 9, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal This pull request does not affect package code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants