Skip to content

[2.x] Update custom exception class to accept previous throwable #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2024
Merged

[2.x] Update custom exception class to accept previous throwable #1800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/framework/src/Framework/Exceptions/InvalidConfigurationException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

namespace Hyde\Framework\Exceptions;

use Throwable;
use Hyde\Facades\Filesystem;
use InvalidArgumentException;

Expand All @@ -13,13 +14,13 @@

class InvalidConfigurationException extends InvalidArgumentException
{
public function __construct(string $message = 'Invalid configuration detected.', ?string $namespace = null, ?string $key = null)
public function __construct(string $message = 'Invalid configuration detected.', ?string $namespace = null, ?string $key = null, ?Throwable $previous = null)
{
if ($namespace && $key) {
[$this->file, $this->line] = $this->findConfigLine($namespace, $key);
}

parent::__construct($message);
parent::__construct($message, previous: $previous);
}

/**
Expand Down
9 changes: 9 additions & 0 deletions packages/framework/tests/Unit/CustomExceptionsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,4 +201,13 @@ public function testInvalidConfigurationExceptionWithNamespaceAndKey()
$this->assertStringContainsString('config'.DIRECTORY_SEPARATOR.'hyde.php', $exception->getFile());
$this->assertGreaterThan(0, $exception->getLine());
}

public function testInvalidConfigurationExceptionWithPreviousThrowable()
{
$previous = new Exception('Previous exception.');
$exception = new InvalidConfigurationException('Invalid configuration.', 'hyde', 'name', $previous);

$this->assertSame('Invalid configuration.', $exception->getMessage());
$this->assertSame($previous, $exception->getPrevious());
}
}