[2.x] Remove the deprecated BaseUrlNotSetException class
#1760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…move-the-base-url-not-set-exception-class
emmadesilva
force-pushed
the
remove-the-base-url-not-set-exception-class
branch
from
94e6fcd to
f25ef59
Compare
emmadesilva
force-pushed
the
remove-the-base-url-not-set-exception-class
branch
2 times, most recently
from
e900928 to
ac8c172
Compare
Updates the `Hyde::url()` helper to return null instead of throwing when no site URL is set
emmadesilva
force-pushed
the
remove-the-base-url-not-set-exception-class
branch
from
ac8c172 to
e45185a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x-dev #1760 +/- ##
==========================================
Coverage ? 99.97%
Complexity ? 1809
==========================================
Files ? 185
Lines ? 4788
Branches ? 0
==========================================
Hits ? 4787
Misses ? 1
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Changes to the URL helper is mostly reverted in #1890 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes part two of #1758. See #1759 for part one.