Skip to content

Conversation

@emmadesilva
Copy link
Member

@emmadesilva emmadesilva commented Apr 29, 2024

Changes here can now be cherry picked to master as none of these are breaking, as only the implementations are refactored, but none of the APIs.

@emmadesilva emmadesilva force-pushed the refactor-filesystem-helpers branch from 31bdc91 to 2872b8e Compare April 29, 2024 12:21
@codecov
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (88e3c5e) to head (2872b8e).

❗ Current head 2872b8e differs from pull request most recent head d520dc0. Consider uploading reports for the commit d520dc0 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             2.x-dev    #1698      +/-   ##
=============================================
- Coverage      99.97%   99.97%   -0.01%     
+ Complexity      1773     1769       -4     
=============================================
  Files            183      183              
  Lines           4714     4706       -8     
=============================================
- Hits            4713     4705       -8     
  Misses             1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmadesilva emmadesilva marked this pull request as ready for review April 29, 2024 12:27
@emmadesilva emmadesilva merged commit 3d348c9 into 2.x-dev Apr 29, 2024
@emmadesilva emmadesilva deleted the refactor-filesystem-helpers branch April 29, 2024 12:28
emmadesilva added a commit that referenced this pull request Apr 29, 2024
@emmadesilva emmadesilva added this to the v2 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants