Skip to content

Conversation

@emmadesilva
Copy link
Member

@emmadesilva emmadesilva commented Feb 18, 2024

It's kinda weird that we've been using 'other' as a sort of pseudo-null state. It only makes sense for the group to be other when there are other groups, so that should be handled in the frontend Blade, thus we instead now null coalesce to 'Other' when creating the group title.

This is breaking and targets V2 (specifically #1568)

@emmadesilva emmadesilva added the run-visual-tests Internal label to trigger Browserstack visual testing label Feb 18, 2024
@codecov
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4dca8c5) 100.00% compared to head (4be1a45) 100.00%.

❗ Current head 4be1a45 differs from pull request most recent head 3ce0967. Consider uploading reports for the commit 3ce0967 to get more accurate results

Additional details and impacted files
@@                        Coverage Diff                        @@
##             improved-navigation-internals     #1572   +/-   ##
=================================================================
  Coverage                           100.00%   100.00%           
+ Complexity                            1761      1760    -1     
=================================================================
  Files                                  184       184           
  Lines                                 4765      4765           
=================================================================
  Hits                                  4765      4765           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmadesilva emmadesilva marked this pull request as ready for review February 18, 2024 20:57
@emmadesilva emmadesilva merged commit ebbe666 into improved-navigation-internals Feb 18, 2024
@emmadesilva emmadesilva deleted the change-default-documentation-page-group-to-be-null-instead-of-other branch February 18, 2024 20:58
@emmadesilva emmadesilva removed the run-visual-tests Internal label to trigger Browserstack visual testing label Mar 18, 2024
@emmadesilva emmadesilva added this to the v2 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants