Skip to content

[2.x] Remove unused internal DocumentationSearchPage::generate() method #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emmadesilva merged 1 commit into from
Feb 13, 2024
Merged

[2.x] Remove unused internal DocumentationSearchPage::generate() method #1569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ This serves two purposes:
### Removed
- Breaking: Removed the build task `\Hyde\Framework\Actions\PostBuildTasks\GenerateSearch` (see upgrade guide below)
- Breaking: Removed the deprecated `\Hyde\Framework\Services\BuildService::transferMediaAssets()` method (see upgrade guide below)
- Internal: Removed the internal `DocumentationSearchPage::generate()` method as it was unused in https://github.com/hydephp/develop/pull/1569

### Fixed
- for any bug fixes.
Expand Down
11 changes: 0 additions & 11 deletions packages/framework/src/Framework/Features/Documentation/DocumentationSearchPage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
use Hyde\Pages\DocumentationPage;
use Hyde\Pages\Concerns\HydePage;
use Hyde\Support\Models\RouteKey;
use Hyde\Framework\Actions\StaticPageBuilder;
use Hyde\Facades\Config;

/**
Expand All @@ -21,16 +20,6 @@
*/
class DocumentationSearchPage extends InMemoryPage
{
/**
* Generate the search page and save it to disk.
*
* @return string The path to the generated file.
*/
public static function generate(): string
{
return StaticPageBuilder::handle(new static());
}

/**
* Create a new DocumentationSearchPage instance.
*/
Expand Down