Fix bug causing files starting with underscores to add empty values to the file collection array #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ving-a-page-file-starting-with-an-underscore-after-updating-to-v044x' of https://github.com/hydephp/develop into fix-139-error-caused-in-generatesnavigationmenu-when-having-a-page-file-starting-with-an-underscore-after-updating-to-v044x
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
=========================================
Coverage 99.23% 99.23%
- Complexity 761 762 +1
=========================================
Files 97 97
Lines 1970 1971 +1
=========================================
+ Hits 1955 1956 +1
Misses 15 15
Continue to review full report at Codecov.
|
caendesilva
deleted the
fix-139-error-caused-in-generatesnavigationmenu-when-having-a-page-file-starting-with-an-underscore-after-updating-to-v044x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the underlying problem for this the navigation menu bug, which this will fix #139. See that thread for the error and the fix details.