Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default values from Hyde facade method annotations #1275

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Remove default values from Hyde facade method annotations #1275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e7f2e8
Revert "Add default values to method annotations"
caendesilva Mar 14, 2023
08582d7
Update RELEASE_NOTES.md
caendesilva Mar 14, 2023
6d0383b
Merge branch 'master' into remove-default-values-from-hyde-facade-met…
caendesilva Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ This serves two purposes:

### Removed
- Removed IDE helpers for removed global variables from the IDE helper file. https://github.com/hydephp/develop/pull/1274
- Removed default values from Hyde facade method annotations

### Fixed
- for any bug fixes.
Expand Down
12 changes: 6 additions & 6 deletions packages/framework/src/Hyde.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
* @copyright 2022 Caen De Silva
* @license MIT License
*
* @method static string path(string $path = '') $basePath
* @method static string path(string $path = '')
* @method static string vendorPath(string $path = '', string $package = 'framework')
* @method static string pathToAbsolute(string $path)
* @method static string pathToRelative(string $path)
Expand All @@ -43,11 +43,11 @@
* @method static string trimSlashes(string $string)
* @method static HtmlString markdown(string $text, bool $stripIndentation = false)
* @method static string currentPage()
* @method static string getBasePath() $basePath
* @method static string getSourceRoot() ''
* @method static string getOutputDirectory() '_site'
* @method static string getMediaDirectory() '_media'
* @method static string getMediaOutputDirectory() 'media'
* @method static string getBasePath()
* @method static string getSourceRoot()
* @method static string getOutputDirectory()
* @method static string getMediaDirectory()
* @method static string getMediaOutputDirectory()
* @method static Features features()
* @method static FileCollection files()
* @method static PageCollection pages()
Expand Down