Merge pull request #2312 from hydephp/remove-run-prettier-flag

[2.x] Remove --run-prettier flag from the build command

Author: emmadesilva

RELEASE_NOTES.md

@@ -74,6 +74,7 @@ This serves two purposes:
 - **Breaking:** Renamed the `hyde.enable_cache_busting` configuration option to `hyde.cache_busting` in [#1980](https://github.com/hydephp/develop/pull/1980)
 - **Breaking:** Renamed the `hyde.navigation.subdirectories` configuration option to `hyde.navigation.subdirectory_display` in [#1818](https://github.com/hydephp/develop/pull/1818)
 - **Breaking:** Replaced `--run-dev` and `--run-prod` build command flags with a single `--vite` flag that uses Vite to build assets in [#2013](https://github.com/hydephp/develop/pull/2013)
+- **Breaking:** Removed `--run-prettier` build command flag and Prettier dependency in [#2312](https://github.com/hydephp/develop/pull/2312)
 - **Breaking:** The `Author::create()` method now returns an array instead of a `PostAuthor` instance in [#1798](https://github.com/hydephp/develop/pull/1798) For more information, see below.
 - **Breaking:** The `Author::get()` method now returns `null` if an author is not found, rather than creating a new instance in [#1798](https://github.com/hydephp/develop/pull/1798)  For more information, see below.
 - **Breaking:** The `hyde.authors` config setting should now be keyed by the usernames in [#1782](https://github.com/hydephp/develop/pull/1782) For more information, see below.
@@ -577,6 +578,7 @@ The new asset system is a complete rewrite of the HydeFront asset handling syste
 - Replaced Laravel Mix with Vite. ([#2010])
     - You must now use `npm run build` to compile your assets, instead of `npm run prod`.
 - Removed `--run-dev` and `--run-prod` build command flags, replaced by `--vite`. ([#2013])
+- Removed `--run-prettier` build command flag.
 - Removed `DocumentationPage::getTableOfContents()` method. Table of contents are now generated using a Blade component. ([#2045])
 - Removed `hyde.css` from HydeFront, requiring recompilation of assets if you were extending it. ([#2037])
 - Changed how HydeFront is included in projects.  Instead of separate `hyde.css` and `app.css`, all styles are now in `app.css`. ([#2024])

docs/getting-started/console-commands.md

@@ -66,19 +66,18 @@ Here is a quick reference of all the available commands. You can also run `php h
 <a name="build" style="display: inline-block; position: absolute; margin-top: -5rem;"></a>
 
 ```bash
-php hyde build [--vite] [--run-prettier] [--pretty-urls] [--no-api]
+php hyde build [--vite] [--pretty-urls] [--no-api]
 ```
 
 Build the static site
 
 #### Options
 
-|                  |                                            |
-|------------------|--------------------------------------------|
-| `--vite`         | Build frontend assets using Vite           |
-| `--run-prettier` | Format the output using NPM Prettier       |
-| `--pretty-urls`  | Should links in output use pretty URLs?    |
-| `--no-api`       | Disable API calls, for example, Torchlight |
+|                 |                                            |
+|-----------------|--------------------------------------------|
+| `--vite`        | Build frontend assets using Vite           |
+| `--pretty-urls` | Should links in output use pretty URLs?    |
+| `--no-api`      | Disable API calls, for example, Torchlight |
 
 ## Run the static site builder for a single file
 

package-lock.json

@@ -12,7 +12,6 @@
         "hyde-vite-plugin": "^1.0.0-RC.5",
         "hydefront": "^4.0.0-RC.1",
         "postcss": "^8.5.6",
-        "prettier": "3.6.2",
         "tailwindcss": "^4.1.13",
         "vite": "^7.1.7"
     }

package.json

@@ -27,7 +27,6 @@ class BuildSiteCommand extends Command
     /** @var string */
     protected $signature = 'build
         {--vite : Build frontend assets using Vite}
-        {--run-prettier : Format the output using NPM Prettier}
         {--pretty-urls : Should links in output use pretty URLs?}
         {--no-api : Disable API calls, for example, Torchlight}
         {--run-dev : [Removed] Use --vite instead}
@@ -98,14 +97,6 @@ protected function runPreBuildActions(): void
     public function runPostBuildActions(): void
     {
         $this->taskService->runPostBuildTasks();
-
-        if ($this->option('run-prettier')) {
-            $this->runNodeCommand(
-                'npx prettier '.Hyde::pathToRelative(Hyde::sitePath()).'/**/*.html --write --bracket-same-line',
-                'Prettifying code!',
-                'prettify code'
-            );
-        }
     }
 
     protected function printFinishMessage(float $timeStart): void

packages/framework/src/Console/Commands/BuildSiteCommand.php

@@ -158,13 +158,11 @@ public function testNodeActionOutputs()
     {
         Process::fake();
 
-        $this->artisan('build --run-prettier --vite')
+        $this->artisan('build --vite')
             ->expectsOutput('Building frontend assets for production! This may take a second.')
-            ->expectsOutput('Prettifying code! This may take a second.')
             ->assertExitCode(0);
 
         Process::assertRan(fn ($process) => $process->command === 'npm run build');
-        Process::assertRan(fn ($process) => $process->command === 'npx prettier '.Hyde::pathToRelative(Hyde::sitePath()).'/**/*.html --write --bracket-same-line');
     }
 
     public function testPrettyUrlsOptionOutput()

packages/framework/tests/Feature/StaticSiteServiceTest.php

@@ -12,7 +12,6 @@
         "hyde-vite-plugin": "^1.0.0-RC.5",
         "hydefront": "^4.0.0-RC.1",
         "postcss": "^8.5.6",
-        "prettier": "3.6.2",
         "tailwindcss": "^4.1.13",
         "vite": "^7.1.7"
     }