-
-
Notifications
You must be signed in to change notification settings - Fork 12
[2.x] Remove --run-prettier flag from the build command #2312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The --run-prettier flag and its related code have been removed from the build command, documentation, and tests. This is a breaking change and is reflected in the release notes and user documentation.
f413c89 to
c4d787a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2312 +/- ##
===========================================
Coverage 100.00% 100.00%
+ Complexity 2001 2000 -1
===========================================
Files 197 197
Lines 5180 5174 -6
===========================================
- Hits 5180 5174 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Prettier has been removed from both root and package dependencies, as well as from the build command flags. The release notes have been updated to reflect the removal of both the --run-prettier flag and the Prettier dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the --run-prettier flag from Hyde's build command to simplify the build pipeline and eliminate unnecessary overhead. The change removes an experimental feature that provided little practical value while adding complexity.
- Removes the
--run-prettierCLI option and associated code logic - Eliminates Prettier as a dependency from package.json files
- Updates documentation and tests to reflect the removal
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/hyde/package.json | Removes Prettier dependency |
| packages/framework/tests/Feature/StaticSiteServiceTest.php | Updates test to remove Prettier-related assertions |
| packages/framework/src/Console/Commands/BuildSiteCommand.php | Removes --run-prettier option and post-build Prettier execution |
| package.json | Removes Prettier dependency from root package |
| docs/getting-started/console-commands.md | Updates CLI documentation to remove Prettier option |
| RELEASE_NOTES.md | Documents the breaking change in release notes |
Files not reviewed (1)
- packages/hyde/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This PR removes the --run-prettier flag and all related code, documentation, and tests.
Motivation
Impact
Removed the package too