Skip to content

Conversation

@emmadesilva
Copy link
Member

@emmadesilva emmadesilva commented Sep 30, 2025

This PR removes the --run-prettier flag and all related code, documentation, and tests.

Motivation

  • Performance & simplicity: Running Prettier on build output adds unnecessary overhead for little practical benefit. The generated HTML is already valid and production-ready, and formatting has no effect on runtime performance or user experience.
  • User value: In practice, very few (if any) users run Prettier against compiled output. The feature was more of a “nice to have” experiment than a workflow essential. Removing it reduces cognitive load for new users and avoids advertising a feature that isn’t meaningfully useful.
  • Maintainability: Keeping the option meant carrying extra code, documentation, and test coverage for a niche feature. Dropping it makes the build pipeline leaner and easier to maintain long-term.
  • Consistency: Hyde v2 aims to streamline the CLI and remove legacy/experimental flags. This change aligns the build command with the philosophy of providing clear, purposeful options.

Impact

  • This is a breaking change since the --run-prettier option no longer exists. It has been removed from the CLI, docs, and tests.
  • The removal is clearly reflected in the release notes and user documentation.
  • Users who still want to format output can add their own npm run prettier step post-build.

Removed the package too

  • Note that this also removes the Prettier package from the project as we no longer use it

@emmadesilva emmadesilva temporarily deployed to pr-documentation-2312 September 30, 2025 09:06 — with GitHub Actions Inactive
@emmadesilva emmadesilva changed the title Remove --run-prettier flag from the build command [2.x] Remove --run-prettier flag from the build command Sep 30, 2025
The --run-prettier flag and its related code have been removed from the build command, documentation, and tests. This is a breaking change and is reflected in the release notes and user documentation.
@emmadesilva emmadesilva force-pushed the remove-run-prettier-flag branch from f413c89 to c4d787a Compare September 30, 2025 09:08
@emmadesilva emmadesilva temporarily deployed to pr-documentation-2312 September 30, 2025 09:08 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d6b0fbf) to head (240ab49).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master     #2312   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity      2001      2000    -1     
===========================================
  Files            197       197           
  Lines           5180      5174    -6     
===========================================
- Hits            5180      5174    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Prettier has been removed from both root and package dependencies, as well as from the build command flags. The release notes have been updated to reflect the removal of both the --run-prettier flag and the Prettier dependency.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the --run-prettier flag from Hyde's build command to simplify the build pipeline and eliminate unnecessary overhead. The change removes an experimental feature that provided little practical value while adding complexity.

  • Removes the --run-prettier CLI option and associated code logic
  • Eliminates Prettier as a dependency from package.json files
  • Updates documentation and tests to reflect the removal

Reviewed Changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/hyde/package.json Removes Prettier dependency
packages/framework/tests/Feature/StaticSiteServiceTest.php Updates test to remove Prettier-related assertions
packages/framework/src/Console/Commands/BuildSiteCommand.php Removes --run-prettier option and post-build Prettier execution
package.json Removes Prettier dependency from root package
docs/getting-started/console-commands.md Updates CLI documentation to remove Prettier option
RELEASE_NOTES.md Documents the breaking change in release notes
Files not reviewed (1)
  • packages/hyde/package-lock.json: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@emmadesilva emmadesilva merged commit 277ccaf into master Sep 30, 2025
21 checks passed
@emmadesilva emmadesilva deleted the remove-run-prettier-flag branch September 30, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants