Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ble: simplify and substitute errors.Wrap() #958

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Jun 14, 2023

Solved issues and/or description of the change

Archived package ""github.com/pkg/errors" now removed from gobot, see #952 . Additionally:

  • multiple wrapping of the same error was removed in "ble_client_adaptor.go".
  • go.mod and go.sum cleaned

Manual test

no

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • New and existing unit tests pass locally with my changes (e.g. by run make test)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

@gen2thomas gen2thomas marked this pull request as ready for review June 14, 2023 16:26
@gen2thomas gen2thomas merged commit 314a808 into hybridgroup:dev Jun 14, 2023
@gen2thomas gen2thomas deleted the fix/remove_mod_dep branch June 14, 2023 16:27
"os"

"gobot.io/x/gobot/v2"

paho "github.com/eclipse/paho.mqtt.golang"
"github.com/pkg/errors"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't it be just "errors"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this would be also possible, but a good practice is to use one of "fmt.Errorf()" or "errors.New()" in one file (some say also in one project)

gen2thomas added a commit to gen2thomas/gobot that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants