Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i2c(core): fix problems with usage of uintptr #1033

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Nov 11, 2023

Solved issues and/or description of the change

null reference exception in i2c core drivers when test with test -race, caused by GC - fixed by using an additional parameter for address instead of try to reuse the payload parameter and use a unsafe.Pointer instead of uintptr for the last parameter in test mocks for syscall

this partially fix #1017

Manual test

  • OS and Version (Win/Mac/Linux): Linux
  • Adaptor(s) and/or driver(s): tinkerboard with PCA9533 and ADS1115

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • New and existing unit tests pass locally with my changes (e.g. by run make test)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

@gen2thomas gen2thomas marked this pull request as ready for review November 11, 2023 18:30
@gen2thomas gen2thomas merged commit 04fa579 into hybridgroup:dev Nov 11, 2023
1 check passed
@gen2thomas gen2thomas deleted the fix/gc_i2c branch November 11, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant