Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose breakpoints by rejection sampling #102

Open
hyanwong opened this issue Mar 7, 2024 · 1 comment
Open

Choose breakpoints by rejection sampling #102

hyanwong opened this issue Mar 7, 2024 · 1 comment

Comments

@hyanwong
Copy link
Owner

hyanwong commented Mar 7, 2024

@duncanMR points out that it could be much more efficient to pick a point in U for recombination, and try to find an equivalent point in V, retrying if we don't succeed.

This is a very good point. It will not give quite the same answer if there are different lengths of shared sequence in U vs V, as a result of duplications, but it should be quite close. It should deal fine with inversions and deletions though (as these won't have shared MRCAs, and will simply be re-tried)

This would be a good way to speed up the forward simulation (see #86 )

@hyanwong
Copy link
Owner Author

hyanwong commented Jul 8, 2024

We would still need to percolate all the intervals up from V until we intersect with the an interval containing the target position in U, but this is probably a lot less costly than doing every interval in U.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant